From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757437AbYBNPA4 (ORCPT ); Thu, 14 Feb 2008 10:00:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753848AbYBNPAQ (ORCPT ); Thu, 14 Feb 2008 10:00:16 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:33297 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbYBNPAJ (ORCPT ); Thu, 14 Feb 2008 10:00:09 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=KDIWdymrjJ7EDy92RGHVNT/iCH7704CySFYtl2j2ZKmXO5inkB2zf3TSNoFmimrjAmOBNRRUOlp9moZ+PA0tm4h0sbIGcRjfe868hZUtBoBfw7SbNMVssgfWuS/tSI83RBHrgLl/6fgDqltpJSpoKu8tmLqTteY7IRIJyhnsXb4= Message-ID: <47B45773.3090203@gmail.com> Date: Thu, 14 Feb 2008 16:00:03 +0100 From: Jiri Slaby User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: Jiri Slaby CC: Sergio Luis , James Bottomley , SCSI Mailing List , Jeff Garzik , Linux Kernel Mailing List Subject: Re: "gdth: update deprecated pci_find_device" is incorrect References: <47B453D3.5060707@gmail.com> <47B45469.5070103@gmail.com> In-Reply-To: <47B45469.5070103@gmail.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/2008 03:47 PM, Jiri Slaby wrote: > On 02/14/2008 03:44 PM, Jiri Slaby wrote: >> Hi, >> >> commit >> 99109301d103fbf0de43fc5a580a406c12a501e0 >> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci >> refcount on exit. Also you do not so on fail paths... I wonder why >> these mistakes happen every second time somebody tries to do such change. >> >> It leaked into mainline yet after "whole" two days, but what exactly >> drives me crazy is, that Jeff commented it in similar way and nobody >> reflected it! Yeah, you did (I read the thread on wrong server obviusly), sorry...