From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
ak@suse.de, mingo@elte.hu, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] x86: lds - Use THREAD_SIZE instead of numeric constant
Date: Sun, 17 Feb 2008 12:11:45 -0800 [thread overview]
Message-ID: <47B89501.5090108@zytor.com> (raw)
In-Reply-To: <20080217200654.GF31968@cvg>
Cyrill Gorcunov wrote:
>
> Thanks Peter for comments. Peter could you clarify for me a bit
> more on the string:
>
> x86/kernel/head_32.S:339
>
> /* Set up the stack pointer */
> lss stack_start,%esp
>
> but stack_start is defined as head_32.S:647
>
> .data
> ENTRY(stack_start)
> .long init_thread_union+THREAD_SIZE
>
> so stack_start *must* be aligned with THREAD_SIZE in vmlinux.lds
> at compiling time. There is no PDA at this booting time. Am I wrong?
> If you're too busy - just reply me like "Read the code" ;)
>
That doesn't follow.
You're saying that it *must* be aligned, I don't think that's true
anymore; I think nowadays it's more accurate to say that it *is*
aligned, but I don't think that's fundamental.
-hpa
next prev parent reply other threads:[~2008-02-17 20:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 15:17 [patch 0/2] x86: vmlinux.lds cleanup Cyrill Gorcunov
2008-02-17 15:17 ` [patch 1/2] x86: lds - Use PAGE_SIZE instead of numeric constant Cyrill Gorcunov
2008-02-17 18:57 ` Sam Ravnborg
2008-02-17 19:09 ` Ingo Molnar
2008-02-17 15:17 ` [patch 2/2] x86: lds - Use THREAD_SIZE " Cyrill Gorcunov
2008-02-17 18:59 ` Sam Ravnborg
2008-02-17 19:08 ` Cyrill Gorcunov
2008-02-17 19:48 ` H. Peter Anvin
2008-02-17 20:06 ` Cyrill Gorcunov
2008-02-17 20:11 ` H. Peter Anvin [this message]
2008-02-17 20:15 ` Cyrill Gorcunov
2008-02-18 14:27 ` Andi Kleen
2008-02-17 19:08 ` Ingo Molnar
2008-02-17 19:26 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B89501.5090108@zytor.com \
--to=hpa@zytor.com \
--cc=ak@suse.de \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox