* [PATCH 6/7] cgroup: remove duplicate code in find_css_set()
@ 2008-02-18 5:49 Li Zefan
2008-02-20 3:02 ` Paul Menage
0 siblings, 1 reply; 2+ messages in thread
From: Li Zefan @ 2008-02-18 5:49 UTC (permalink / raw)
To: Andrew Morton; +Cc: Paul Menage, KAMEZAWA Hiroyuki, LKML, containers
The list head res->tasks gets initialized twice in find_css_set().
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/cgroup.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e8c8e58..71cf961 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -473,7 +473,6 @@ static struct css_set *find_css_set(
/* Link this cgroup group into the list */
list_add(&res->list, &init_css_set.list);
css_set_count++;
- INIT_LIST_HEAD(&res->tasks);
write_unlock(&css_set_lock);
return res;
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/7] cgroup: remove duplicate code in find_css_set()
2008-02-18 5:49 [PATCH 6/7] cgroup: remove duplicate code in find_css_set() Li Zefan
@ 2008-02-20 3:02 ` Paul Menage
0 siblings, 0 replies; 2+ messages in thread
From: Paul Menage @ 2008-02-20 3:02 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, KAMEZAWA Hiroyuki, LKML, containers
On Feb 17, 2008 9:49 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> The list head res->tasks gets initialized twice in find_css_set().
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Paul Menage <menage@google.com>
> ---
> kernel/cgroup.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index e8c8e58..71cf961 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -473,7 +473,6 @@ static struct css_set *find_css_set(
> /* Link this cgroup group into the list */
> list_add(&res->list, &init_css_set.list);
> css_set_count++;
> - INIT_LIST_HEAD(&res->tasks);
> write_unlock(&css_set_lock);
>
> return res;
> --
> 1.5.4.rc3
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-20 3:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-18 5:49 [PATCH 6/7] cgroup: remove duplicate code in find_css_set() Li Zefan
2008-02-20 3:02 ` Paul Menage
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox