From: Li Zefan <lizf@cn.fujitsu.com>
To: akpm@linux-foundation.org
Cc: balbir@linux.vnet.ibm.com, containers@lists.linux-foundation.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] memcgroup: remove a useless VM_BUG_ON()
Date: Mon, 18 Feb 2008 15:34:48 +0800 [thread overview]
Message-ID: <47B93518.6@cn.fujitsu.com> (raw)
In-Reply-To: <47B92D47.2050008@linux.vnet.ibm.com>
Remove this VM_BUG_ON(), as Balbir stated:
We used to have a for loop with !list_empty() as a termination condition
and VM_BUG_ON(!pc) is a spill over. With the new loop, VM_BUG_ON(!pc) does not
make sense.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
mm/memcontrol.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 718acf8..631002d 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -534,7 +534,6 @@ unsigned long mem_cgroup_isolate_pages(unsigned long nr_to_scan,
if (scan >= nr_to_scan)
break;
page = pc->page;
- VM_BUG_ON(!pc);
if (unlikely(!PageLRU(page)))
continue;
--
1.5.4.rc3
next prev parent reply other threads:[~2008-02-18 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 5:59 [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() Li Zefan
2008-02-18 6:14 ` Balbir Singh
2008-02-18 6:22 ` YAMAMOTO Takashi
2008-02-18 6:20 ` Balbir Singh
2008-02-18 6:47 ` Li Zefan
2008-02-18 7:01 ` Balbir Singh
2008-02-18 7:14 ` Li Zefan
2008-02-18 7:34 ` Li Zefan [this message]
2008-02-18 8:12 ` [PATCH] memcgroup: remove a useless VM_BUG_ON() Balbir Singh
2008-02-18 8:48 ` KAMEZAWA Hiroyuki
2008-02-18 6:39 ` [PATCH 2/3] memcgroup: fix typo in VM_BUG_ON() YAMAMOTO Takashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B93518.6@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox