linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shi Weihua <shiwh@cn.fujitsu.com>
To: Valdis.Kletnieks@vt.edu
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check
Date: Tue, 19 Feb 2008 10:11:23 +0800	[thread overview]
Message-ID: <47BA3ACB.30408@cn.fujitsu.com> (raw)
In-Reply-To: <26325.1203357921@turing-police.cc.vt.edu>



Valdis.Kletnieks@vt.edu wrote::
> On Mon, 18 Feb 2008 18:22:05 +0800, Shi Weihua said:
> 
>> -	/*
>> -	 * If we are on the alternate signal stack and would overflow it, don't.
>                                                                    notice this ^
>> -	 * Return an always-bogus address instead so we will die with SIGSEGV.
> 
>> +			 * If we are on the alternate signal stack and would
>> +			 * overflow it, don't return an always-bogus address
>                                 missing here ^
>> +			 * instead so we will die with SIGSEGV.
> 
> "don't. Return" is a vastly different semantic than "don't return".
> 
> I think the same comment error was cut-n-pasted into all 5 patches...
> 

Sorry, it's my mistake.
I will correct the all 5 patches. Thanks.


  reply	other threads:[~2008-02-19  2:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 10:22 [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check Shi Weihua
2008-02-18 13:47 ` Ingo Molnar
2008-02-19  0:58   ` Shi Weihua
2008-02-19 18:50     ` Roland McGrath
2008-02-20  0:49       ` Shi Weihua
2008-02-20  1:18         ` Roland McGrath
2008-02-20  1:35           ` Shi Weihua
2008-02-20  1:44             ` Roland McGrath
2008-02-20  2:23               ` Shi Weihua
2008-02-20  2:49                 ` Roland McGrath
2008-02-20  2:59                   ` Shi Weihua
2008-02-20  5:54                   ` Harvey Harrison
2008-02-20  7:59                     ` Roland McGrath
2008-02-20 10:27                   ` Ingo Molnar
2008-02-18 18:05 ` Valdis.Kletnieks
2008-02-19  2:11   ` Shi Weihua [this message]
2008-02-19  2:19 ` Shi Weihua
2008-02-19 11:05   ` Ingo Molnar
2008-02-19 23:21     ` Paul Mackerras
2008-02-19 23:25       ` H. Peter Anvin
2008-02-20  0:03         ` Roland McGrath
2008-02-20  0:04       ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BA3ACB.30408@cn.fujitsu.com \
    --to=shiwh@cn.fujitsu.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).