Re: [PATCH] fs/ext4/mballoc.c: Convert to list_for_each_entry_rcu()

Roel Kluin
2008-02-19T15:47:59Z

Aneesh Kumar K.V wrote:
> On Tue, Feb 19, 2008 at 01:31:18AM +0100, Roel Kluin wrote:
>> Please verify, this patch was not yet tested
>> ---
>> Convert list_for_each_rcu() to list_for_each_entry_rcu()
>>
>> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
>
>
> NACK. This patch doesn't build. You have extra cur in the conversion.
> Right changes attached.
>
> ext4: Convert list_for_each_rcu() to list_for_each_entry_rcu()
>
> From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>
> The list_for_each_entry_rcu() primitive should be used instead of
> list_for_each_rcu(), as the former is easier to use and provides
> better type safety.

Thanks for your review and correction,

Roel