From: Jiri Slaby <jirislaby@gmail.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Valdis.Kletnieks@vt.edu,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
roland@redhat.com, linux-kernel@vger.kernel.org,
Pavel Emelyanov <xemul@openvz.org>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: tty && pid problems
Date: Wed, 20 Feb 2008 20:00:44 +0100 [thread overview]
Message-ID: <47BC78DC.7060507@gmail.com> (raw)
In-Reply-To: <20080220162858.GC146@tv-sign.ru>
On 02/20/2008 05:28 PM, Oleg Nesterov wrote:
> I think you can revert the tty-bkl-pushdown.patch. Or, as Eric suggested, just
> revert this
>
> @@ -1222,7 +1221,7 @@ static const struct file_operations tty_
> .read = tty_read,
> .write = tty_write,
> .poll = tty_poll,
> - .ioctl = tty_ioctl,
> + .unlocked_ioctl = tty_ioctl,
> .compat_ioctl = tty_compat_ioctl,
> .open = tty_open,
> .release = tty_release,
> @@ -1235,7 +1234,7 @@ static const struct file_operations ptmx
> .read = tty_read,
> .write = tty_write,
> .poll = tty_poll,
> - .ioctl = tty_ioctl,
> + .unlocked_ioctl = tty_ioctl,
> .compat_ioctl = tty_compat_ioctl,
> .open = ptmx_open,
> .release = tty_release,
> @@ -1248,7 +1247,7 @@ static const struct file_operations cons
> .read = tty_read,
> .write = redirected_tty_write,
> .poll = tty_poll,
> - .ioctl = tty_ioctl,
> + .unlocked_ioctl = tty_ioctl,
> .compat_ioctl = tty_compat_ioctl,
> .open = tty_open,
> .release = tty_release,
> @@ -1260,7 +1259,7 @@ static const struct file_operations hung
> .read = hung_up_tty_read,
> .write = hung_up_tty_write,
> .poll = hung_up_tty_poll,
> - .ioctl = hung_up_tty_ioctl,
> + .unlocked_ioctl = hung_up_tty_ioctl,
> .compat_ioctl = hung_up_tty_compat_ioctl,
> .release = tty_release,
> };
>
> chunk.
This would result in unpredictable behaviour. If I left locking apart, ioctl
prototype != unlocked_ioctl prototype.
next prev parent reply other threads:[~2008-02-20 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 18:02 [PATCH] do_signal_stop: use signal_group_exit() Oleg Nesterov
2008-02-16 3:37 ` Andrew Morton
2008-02-16 14:02 ` Oleg Nesterov
2008-02-17 23:10 ` Oleg Nesterov
2008-02-18 4:11 ` Eric W. Biederman
2008-02-19 23:39 ` Valdis.Kletnieks
2008-02-20 16:14 ` [PATCH] (for -mm only) put_pid: make sure we don't free the live pid Oleg Nesterov
2008-02-20 16:18 ` tty && pid problems Oleg Nesterov
2008-02-20 16:19 ` Alan Cox
2008-02-22 1:39 ` Eric W. Biederman
2008-02-22 9:37 ` Alan Cox
2008-02-20 16:28 ` Oleg Nesterov
2008-02-20 19:00 ` Jiri Slaby [this message]
2008-02-20 2:32 ` [PATCH] do_signal_stop: use signal_group_exit() Eric W. Biederman
2008-02-16 15:09 ` [PATCH] free_pidmap: turn it into free_pidmap(struct upid *) Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BC78DC.7060507@gmail.com \
--to=jirislaby@gmail.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ebiederm@xmission.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox