From: Pavel Emelyanov <xemul@openvz.org>
To: Jan Kara <jack@suse.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yuri Per <Yuri.Per@acronis.com>,
Max Lyadvinsky <Max.Lyadvinsky@acronis.com>,
Vladimir Simonov <Vladimir.Simonov@acronis.com>,
Andrew Neporada <Andrew.Neporada@acronis.com>,
Kirill Korotaev <dev@openvz.org>
Subject: [PATCH] UDF: fix anchor point detection
Date: Thu, 21 Feb 2008 11:55:50 +0300 [thread overview]
Message-ID: <47BD3C96.40501@openvz.org> (raw)
According to ECMA 167 rev. 3 (see 3/8.4.2.1), Anchor Volume
Descriptor Pointer should be recorded at two or more anchor
points located at sectors 256, N, N - 256, where N - is a
largest logical sector number at volume space.
So we should always try to detect N on UDF volume before
trying to find Anchor Volume Descriptor (i.e. calling to
udf_find_anchor()).
That said, all this patch does is updates the s_last_block
even if the udf_vrs() returns positive value.
Originally written and tested by Yuri Per, ported on latest
mainline by me.
Signed-off-by: Yuri Per <Yuri.Per@acronis.com>
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Max Lyadvinsky <Max.Lyadvinsky@acronis.com>
Cc: Vladimir Simonov <Vladimir.Simonov@acronis.com>
Cc: Andrew Neporada <Andrew.Neporada@acronis.com>
Cc: Kirill Korotaev <dev@openvz.org>
---
diff --git a/fs/udf/super.c b/fs/udf/super.c
index f3ac4ab..abd5e30 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1486,16 +1486,17 @@ static int udf_check_valid(struct super_block *sb, int novrs, int silent)
/* Check that it is NSR02 compliant */
/* Process any "CD-ROM Volume Descriptor Set" (ECMA 167 2/8.3.1) */
else {
+ struct udf_sb_info *sbi = UDF_SB(sb);
+
block = udf_vrs(sb, silent);
- if (block == -1) {
- struct udf_sb_info *sbi = UDF_SB(sb);
+ if (block == -1)
udf_debug("Failed to read byte 32768. Assuming open "
"disc. Skipping validity check\n");
- if (!sbi->s_last_block)
- sbi->s_last_block = udf_get_last_block(sb);
- return 0;
- } else
- return !block;
+
+ if (block && !sbi->s_last_block)
+ sbi->s_last_block = udf_get_last_block(sb);
+
+ return !block;
}
}
reply other threads:[~2008-02-21 8:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47BD3C96.40501@openvz.org \
--to=xemul@openvz.org \
--cc=Andrew.Neporada@acronis.com \
--cc=Max.Lyadvinsky@acronis.com \
--cc=Vladimir.Simonov@acronis.com \
--cc=Yuri.Per@acronis.com \
--cc=dev@openvz.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox