public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
	"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Make yield_task_fair more efficient
Date: Thu, 21 Feb 2008 15:37:04 +0530	[thread overview]
Message-ID: <47BD4D48.4080606@linux.vnet.ibm.com> (raw)
In-Reply-To: <1203588090.6243.128.camel@lappy>

Peter Zijlstra wrote:
> On Thu, 2008-02-21 at 15:12 +0530, Balbir Singh wrote:
>> Peter Zijlstra wrote:
>>> On Thu, 2008-02-21 at 15:01 +0530, Balbir Singh wrote:
>>>
>>>> I have an alternate approach in mind (that I need to find time for),
>>>> threaded-rbtrees. Walking the tree is really efficient, specially finding
>>>> successor of a node.
>>> Threading the rbtrees would be even more expensive, it would require a
>>> list_head in each node and a full list operation for every tree
>>> operation.
>>>
>> Peter, when I say threaded, I don't mean threaded as in tasks. Please see
>> http://www.nist.gov/dads/HTML/threadedtree.html and
>> http://datastructures.itgo.com/trees/tbt.htm
> 
> I'm quite aware of the meaning of threaded in the context of data
> structures.

Oh! I did not mean to assume anything. Just wanted to make sure we are talking
of the same thing

 They usually require additional list data and operations to
> implement.
> 

>From the definition
A Threaded Binary Tree is a binary tree in which every node that does not have a
right child has a THREAD (in actual sense, a link) to its INORDER successor.

You use the empty pointer (missing right child), so why do we need a list. May
be I am missing something.

> Look at how the latter link you provided grows the rb_node with one
> pointer to provide a single linked list.
> 

Yes, that's a bad example I suppose. Look at
http://www.cs.rutgers.edu/~kaplan/503/thread.html

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

  reply	other threads:[~2008-02-21 10:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21  5:33 Make yield_task_fair more efficient Balbir Singh
2008-02-21  6:04 ` Ingo Molnar
2008-02-21  6:51   ` Balbir Singh
2008-02-21  7:07     ` Ingo Molnar
2008-02-21  7:39       ` Balbir Singh
2008-02-21  8:43         ` Peter Zijlstra
2008-02-21  8:50           ` Balbir Singh
2008-02-21  9:04             ` Ingo Molnar
2008-02-21  9:31               ` Balbir Singh
2008-02-21  9:42                 ` Ingo Molnar
2008-02-21  9:44                   ` Balbir Singh
2008-02-21  9:43                 ` Peter Zijlstra
2008-02-21  9:42                   ` Balbir Singh
2008-02-21 10:01                     ` Peter Zijlstra
2008-02-21 10:07                       ` Balbir Singh [this message]
2008-02-21 11:12                         ` Peter Zijlstra
2008-02-21 11:27                           ` Balbir Singh
2008-02-21 20:38                           ` Jens Axboe
2008-02-21 20:55                             ` Jens Axboe
2008-02-22  3:27                               ` Balbir Singh
2008-02-21 10:17                 ` Balbir Singh
2008-02-21 12:02                 ` Mike Galbraith
2008-02-21 12:06                   ` Mike Galbraith
2008-02-21 13:29                   ` Balbir Singh
2008-02-21 14:38     ` Jörn Engel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BD4D48.4080606@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox