From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932963AbYBUQJf (ORCPT ); Thu, 21 Feb 2008 11:09:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757428AbYBUQJY (ORCPT ); Thu, 21 Feb 2008 11:09:24 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:42298 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755130AbYBUQJX (ORCPT ); Thu, 21 Feb 2008 11:09:23 -0500 Message-ID: <47BDA22F.5060300@pobox.com> Date: Thu, 21 Feb 2008 11:09:19 -0500 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Pavel Machek CC: kernel list , Linux-pm mailing list , linux-ide@vger.kernel.org Subject: Re: power_state: get rid of write-only variable in SATA References: <20080221125652.GA23548@elf.ucw.cz> In-Reply-To: <20080221125652.GA23548@elf.ucw.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.3 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel Machek wrote: > power_state is scheduled for removal, and libata uses it in write-only > mode. Remove it. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c > index b4985bc..a31572d 100644 > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -6542,8 +6542,6 @@ int ata_host_suspend(struct ata_host *ho > ata_lpm_enable(host); > > rc = ata_host_request_pm(host, mesg, 0, ATA_EHI_QUIET, 1); > - if (rc == 0) > - host->dev->power.power_state = mesg; > return rc; > } > > @@ -6562,7 +6560,6 @@ void ata_host_resume(struct ata_host *ho > { > ata_host_request_pm(host, PMSG_ON, ATA_EH_SOFTRESET, > ATA_EHI_NO_AUTOPSY | ATA_EHI_QUIET, 0); > - host->dev->power.power_state = PMSG_ON; > > /* reenable link pm */ > ata_lpm_disable(host); libata uses it under the assumption that "other parts" of the system are aware of this variable. May I assume that the API has changed such that this is no longer necessary? Jeff