From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764927AbYBUUAA (ORCPT ); Thu, 21 Feb 2008 15:00:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755425AbYBUT7w (ORCPT ); Thu, 21 Feb 2008 14:59:52 -0500 Received: from terminus.zytor.com ([198.137.202.10]:35478 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755009AbYBUT7v (ORCPT ); Thu, 21 Feb 2008 14:59:51 -0500 Message-ID: <47BDD820.2050602@zytor.com> Date: Thu, 21 Feb 2008 11:59:28 -0800 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Cyrill Gorcunov CC: Ingo Molnar , Thomas Gleixner , LKML Subject: Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code References: <20080221195022.GA6772@cvg> <47BDD698.9000906@zytor.com> <20080221195628.GB6772@cvg> In-Reply-To: <20080221195628.GB6772@cvg> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cyrill Gorcunov wrote: > [H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800] >> Cyrill Gorcunov wrote: >>> This patch replaces 4096 numeric constant with PAGE_SIZE macro. >>> Signed-off-by: Cyrill Gorcunov >>> --- >>> Text segments of old and new files *are* the same so >>> it wouldn't break current kernel. >> NAK. >> >> This is NOT PAGE_SIZE (even though the two values are coincidentally the >> same, for historical reasons.) >> >> -hpa >> > > hmm, why the comment on boot_param structure definition calls > it "zeropage"? Anyway really thanks for review and catched this. > Historical reasons... it used to be a "magic page" -- that's long since gone. -hpa