From: Jeff Garzik <jeff@garzik.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] [SCSI] gdth: misc cleanups, preparation for ISA/EISA hotplug API
Date: Sun, 24 Feb 2008 00:34:00 -0500 [thread overview]
Message-ID: <47C101C8.2070306@garzik.org> (raw)
In-Reply-To: <20080224053117.GA13904@infradead.org>
Christoph Hellwig wrote:
> On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
>> hmmmmm. We'll see how it plays out... on the remove side, the above is
>> exact what happens in gdth_remove_one() without my patch, thus
>> consolidating two cases of the same code into one. There is a less-strong
>> argument for doing the allocation that way, but it may turn out to be
>> useful anyway once the ISA/EISA API conversion is complete.
>
> EISA ->remove has a different prototype from PCI ->remove from ISA
> ->remove, so gdth_remove_one will be split up eventually. Having the
> scsi_host_put duplicated in each shouldn't be too much of a problem :)
We'll see what the final result is... you might turn out to be right.
If people want to avoid merging this patch because of this issue, that's
fine.
Jeff
next prev parent reply other threads:[~2008-02-24 5:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 4:44 [PATCH 1/1] [SCSI] gdth: misc cleanups, preparation for ISA/EISA hotplug API Jeff Garzik
2008-02-24 4:58 ` Christoph Hellwig
2008-02-24 5:18 ` Jeff Garzik
2008-02-24 5:31 ` Christoph Hellwig
2008-02-24 5:34 ` Jeff Garzik [this message]
2008-02-24 6:37 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C101C8.2070306@garzik.org \
--to=jeff@garzik.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox