compile problem in current x86.git

compile problem in current x86.git

[Jeremy Fitzhardinge]

  CC      arch/x86/kernel/traps_32.o
/home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory


asm-x86/kmemcheck.h does seem to be completely missing.  Looks like 
8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck" 
should have added the file.

    J

Re: compile problem in current x86.git

[Vegard Nossum]

Hello!

On Mon, Feb 25, 2008 at 8:23 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>   CC      arch/x86/kernel/traps_32.o
>  /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory
>
>
>  asm-x86/kmemcheck.h does seem to be completely missing.  Looks like
>  8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck"
>  should have added the file.

Hm. This is x86#testing, no? I don't think there's any kmemcheck code
whatsoever in other branches.

The file should be added with this commit:

kmemcheck: add the kmemcheck core
http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commit;h=c83d05d69382945c92a2e7a2b168c1cc2aa77c29


Vegard

Re: compile problem in current x86.git

[Ingo Molnar]

* Vegard Nossum <vegard.nossum@gmail.com> wrote:

> >  asm-x86/kmemcheck.h does seem to be completely missing.  Looks like 
> >  8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for 
> >  kmemcheck" should have added the file.
> 
> Hm. This is x86#testing, no? I don't think there's any kmemcheck code 
> whatsoever in other branches.
> 
> The file should be added with this commit:
> 
> kmemcheck: add the kmemcheck core 
> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commit;h=c83d05d69382945c92a2e7a2b168c1cc2aa77c29

yes, x86.git looks fine here too:

 ~/linux.trees.git> git-checkout -b tmp x86/testing
 Branch tmp set up to track remote branch refs/remotes/x86/testing.
 Switched to a new branch "tmp"
 ~/linux.trees.git> cd include/asm-x86/
 ~/linux.trees.git/include/asm-x86> ls -l kmemcheck.h
 -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 kmemcheck.h
 ~/linux.trees.git/include/asm-x86> cd ..
 ~/linux.trees.git/include> cd ..
 ~/linux.trees.git> ls -ldt include/asm-x86/kmemcheck.h
 -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 include/asm-x86/kmemcheck.h
 ~/linux.trees.git> git-log | head -1
 commit c9d2f5489cec70f814bf64033290e5f05b4d7f33

	Ingo

Re: compile problem in current x86.git

[Ingo Molnar]

> > Hm. This is x86#testing, no? I don't think there's any kmemcheck 
> > code whatsoever in other branches.

ah. that was x86.git#mm i think - a kmemcheck commit indeed prematurely 
got into that branch.

I've updated x86.git and it should all have the correct ordering now. 
(as of HEAD c9d2f5489cec70f814bf6)

Jeremy, you might want to start tracking x86.git#testing:

  http://people.redhat.com/mingo/x86.git/README

if you want to follow the latest & greatest x86.git code.

	Ingo

Re: compile problem in current x86.git

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> Jeremy, you might want to start tracking x86.git#testing:
>
>   http://people.redhat.com/mingo/x86.git/README
>
> if you want to follow the latest & greatest x86.git code.
>   

Right, will do.

    J

Re: compile problem in current x86.git

[Ingo Molnar]

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
>> Jeremy, you might want to start tracking x86.git#testing:
>>
>>   http://people.redhat.com/mingo/x86.git/README
>>
>> if you want to follow the latest & greatest x86.git code.
>>   
>
> Right, will do.

generally it's as well tested on x86 as #mm (so you should not notice 
any difference while tracking it), but it also includes work in progress 
bits that might touch other subsystems as well.

	Ingo

Re: compile problem in current x86.git

[Jeremy Fitzhardinge]

Ingo Molnar wrote:
> * Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
>   
>>>  asm-x86/kmemcheck.h does seem to be completely missing.  Looks like 
>>>  8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for 
>>>  kmemcheck" should have added the file.
>>>       
>> Hm. This is x86#testing, no? I don't think there's any kmemcheck code 
>> whatsoever in other branches.
>>
>> The file should be added with this commit:
>>
>> kmemcheck: add the kmemcheck core 
>> http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commit;h=c83d05d69382945c92a2e7a2b168c1cc2aa77c29
>>     
>
> yes, x86.git looks fine here too:
>
>  ~/linux.trees.git> git-checkout -b tmp x86/testing
>  Branch tmp set up to track remote branch refs/remotes/x86/testing.
>  Switched to a new branch "tmp"
>  ~/linux.trees.git> cd include/asm-x86/
>  ~/linux.trees.git/include/asm-x86> ls -l kmemcheck.h
>  -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 kmemcheck.h
>  ~/linux.trees.git/include/asm-x86> cd ..
>  ~/linux.trees.git/include> cd ..
>  ~/linux.trees.git> ls -ldt include/asm-x86/kmemcheck.h
>  -rw-rw-r-- 1 mingo mingo 55 2008-02-25 21:41 include/asm-x86/kmemcheck.h
>  ~/linux.trees.git> git-log | head -1
>  commit c9d2f5489cec70f814bf64033290e5f05b4d7f33

I'm using #mm.  Should I be using #testing?

    J