public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josh Triplett <josh@kernel.org>
To: akpm@linux-foundation.org
Cc: fbuihuu@gmail.com, paulmck@linux.vnet.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree
Date: Tue, 26 Feb 2008 03:33:05 -0800	[thread overview]
Message-ID: <47C3F8F1.4010100@kernel.org> (raw)
In-Reply-To: <200802230734.m1N7Ymrp018304@imap1.linux-foundation.org>

[I did not see this patch go by on any mailing list, so I replied to
the -mm mail and CCed LKML.]

akpm@linux-foundation.org wrote:
> The patch titled
>      rcu: split list.h and move rcu-protected lists into rculist.h
> has been added to the -mm tree.  Its filename is
>      rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch
[...]
> Subject: rcu: split list.h and move rcu-protected lists into rculist.h
> From: Franck Bui-Huu <fbuihuu@gmail.com>
> 
> Move rcu-protected lists from list.h into a new header file rculist.h.
> 
> This is done because list are a very used primitive structure all over the
> kernel and it's currently impossible to include other header files in this
> list.h without creating some circular dependencies.
> 
> For example, list.h implements rcu-protected list and uses rcu_dereference()
> without including rcupdate.h.  It actually compiles because users of
> rcu_dereference() are macros.  Others RCU functions could be used too but
> aren't probably because of this.
> 
> Therefore this patch creates rculist.h which includes rcupdates without to
> many changes/troubles.
> 
> Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Josh Triplett <josh@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

This seems fine to me.  Having the headers separate might make it more
difficult to keep the two in sync, but the list primitives don't
change, so that doesn't really matter much.

Acked-by: Josh Triplett <josh@kernel.org>

- Josh Triplett


       reply	other threads:[~2008-02-26 11:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200802230734.m1N7Ymrp018304@imap1.linux-foundation.org>
2008-02-26 11:33 ` Josh Triplett [this message]
2008-02-26 18:31   ` + rcu-split-listh-and-move-rcu-protected-lists-into-rculisth.patch added to -mm tree Franck Bui-Huu
2008-02-26 19:11     ` Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47C3F8F1.4010100@kernel.org \
    --to=josh@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=fbuihuu@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox