From: Li Zefan <lizf@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Paul Jackson <pj@sgi.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] cpuset: fix return value of cpuset_populate()
Date: Wed, 27 Feb 2008 15:36:58 +0800 [thread overview]
Message-ID: <47C5131A.80508@cn.fujitsu.com> (raw)
- no need to check err == 0
- the last return value of cgroup_add_file() is ignored
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
kernel/cpuset.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 3e296ed..1c5b2d2 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -1482,10 +1482,10 @@ static int cpuset_populate(struct cgroup_subsys *ss, struct cgroup *cont)
if ((err = cgroup_add_file(cont, ss, &cft_spread_slab)) < 0)
return err;
/* memory_pressure_enabled is in root cpuset only */
- if (err == 0 && !cont->parent)
+ if (!cont->parent)
err = cgroup_add_file(cont, ss,
&cft_memory_pressure_enabled);
- return 0;
+ return err;
}
/*
--
1.5.4.rc3
next reply other threads:[~2008-02-27 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 7:36 Li Zefan [this message]
2008-02-27 7:41 ` [PATCH] cpuset: fix return value of cpuset_populate() Paul Jackson
2008-02-27 7:46 ` Li Zefan
2008-02-28 0:49 ` Paul Menage
2008-02-28 1:06 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C5131A.80508@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox