From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: Paul Jackson <pj@sgi.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: fix return value of cpuset_populate()
Date: Thu, 28 Feb 2008 09:06:24 +0800 [thread overview]
Message-ID: <47C60910.7000102@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830802271649h29a13ceevf2255dd6235b42ba@mail.gmail.com>
Paul Menage wrote:
> On Tue, Feb 26, 2008 at 11:41 PM, Paul Jackson <pj@sgi.com> wrote:
>> - no need to check err == 0
>> - the last return value of cgroup_add_file() is ignored
>>
>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>
> Looks fine from a cleanliness PoV, although since we don't actually do
> anything with an error result from subsys->populate() (a behaviour
> that I sort of inherited from cpusets ...) it won't make a whole lot
> of difference to the code.
>
> A better change would be to make cpuset_populate() use cgroup_add_files().
>
Yes, I'm considering this, and I will verify if this will save some bytes
in the object file.
prev parent reply other threads:[~2008-02-28 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 7:36 [PATCH] cpuset: fix return value of cpuset_populate() Li Zefan
2008-02-27 7:41 ` Paul Jackson
2008-02-27 7:46 ` Li Zefan
2008-02-28 0:49 ` Paul Menage
2008-02-28 1:06 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C60910.7000102@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox