From: Cedric Le Goater <clg@fr.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] try to fix false positives reports of checkpatch.pl
Date: Thu, 28 Feb 2008 19:09:47 +0100 [thread overview]
Message-ID: <47C6F8EB.4050507@fr.ibm.com> (raw)
From: Cedric Le Goater <clg@fr.ibm.com>
This is an humble attempt to fix these reports that seem to be false positives.
aren't they ? If so, you should triple check the fix because I got lost in the
'elsif' and I took the first shortcut I found :)
Thanks for maintaining checkpatch.pl. it's a great tool.
C.
ERROR: need consistent spacing around '*' (ctx:WxV)
#139: FILE: ipc/mq_sysctl.c:17:
+static void *get_mq(ctl_table *table)
^
ERROR: need consistent spacing around '*' (ctx:WxV)
#148: FILE: ipc/mq_sysctl.c:26:
+static int proc_mq_dointvec(ctl_table *table, int write, struct file *filp,
^
ERROR: need consistent spacing around '*' (ctx:WxV)
#158: FILE: ipc/mq_sysctl.c:36:
+static int proc_mq_dointvec_minmax(ctl_table *table, int write,
^
ERROR: need consistent spacing around '*' (ctx:WxV)
#169: FILE: ipc/mq_sysctl.c:47:
+static int proc_mq_dointvec(ctl_table *table, int write, struct file *filp,
^
ERROR: need consistent spacing around '*' (ctx:WxV)
#175: FILE: ipc/mq_sysctl.c:53:
+static int proc_mq_dointvec_minmax(ctl_table *table, int write,
^
total: 5 errors, 0 warnings, 216 lines checked
Signed-off-by: Cedric Le Goater <clg@fr.ibm.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6.25-rc2-mm1/scripts/checkpatch.pl
===================================================================
--- 2.6.25-rc2-mm1.orig/scripts/checkpatch.pl
+++ 2.6.25-rc2-mm1/scripts/checkpatch.pl
@@ -1387,7 +1387,7 @@ sub process {
$op eq '*' or $op eq '/' or
$op eq '%')
{
- if ($ctx !~ /VxV|WxW|VxE|WxE|VxO/) {
+ if ($ctx !~ /VxV|WxW|VxE|WxE|VxO|WxV/) {
ERROR("need consistent spacing around '$op' $at\n" .
$hereptr);
}
reply other threads:[~2008-02-28 18:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C6F8EB.4050507@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox