Re: [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols

Greg KH
2008-03-04T17:38:29Z

On Tue, Mar 04, 2008 at 09:19:36AM -0800, Linus Torvalds wrote:
> Quite frankly, my position on this has always been that the GPLv2
> explicitly covers _derived_ works only, and that very obviously a Windows
> driver isn't a derived work of the kernel. So as far as I'm concerned,
> ndiswrapper may be distasteful froma technical and support angle, but not
> against the license.

I think ndiswrapper is a great hack from a technical point-of-view. But
yes, I also do not think it is a violation of the GPLv2 for the same
reasons you do.

> So I'm personally perfectly happy to say that we should revert that commit
> 0aa5bd52d0c49ca56d24584c646e6544ccbb3dc9, but what I've wanted to hear
> from the very beginning was simply to get a list of symbols that currently
> clash, and hear from the people who maintain the symbols whether they
> really meant for that commit to be valid.
>
> That's the only issue here. Not whether ndiswrapper could do a part of its
> job in user space (because the answer to that latter question is: no.
> Everything is "possible", of course, but realistically, that's simply not
> going to happen).
>
> It sounds like there aren't that many symbols affected at the core: the
> workqueue stuff certainly isn't worth bothering about. The USB things that
> ndiswrapper wants is much more involved, and more likely to have issues,
> but I'm cc'ing Greg here to see.

I have no objection to reverting that patch to have nidiswrapper access
to those symbols, especially as that is really the only way they will be
able to control USB devices (as you state, doing a network driver in
userspace doesn't really make sense.)

thanks,

greg k-h