Re: [PATCH] saa7146: fix sparse warnings

Dmitri Vorobiev
2008-03-02T17:34:20Z

Harvey Harrison пишет:
> Went along with the existing file style.
> drivers/media/common/saa7146_core.c:309:6: warning: Using plain integer as NULL pointer
> drivers/media/common/saa7146_core.c:311:8: warning: Using plain integer as NULL pointer
> drivers/media/common/saa7146_core.c:319:7: warning: Using plain integer as NULL pointer
> drivers/media/common/saa7146_core.c:319:28: warning: Using plain integer as NULL pointer
> drivers/media/common/saa7146_core.c:325:7: warning: Using plain integer as NULL pointer
> drivers/media/common/saa7146_core.c:325:28: warning: Using plain integer as NULL pointer
> drivers/media/common/saa7146_fops.c:275:12: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/media/common/saa7146_core.c | 8 ++++----
> drivers/media/common/saa7146_fops.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/common/saa7146_core.c b/drivers/media/common/saa7146_core.c
> index 168a8d3..8c755a1 100644
> --- a/drivers/media/common/saa7146_core.c
> +++ b/drivers/media/common/saa7146_core.c
> @@ -306,9 +306,9 @@ static irqreturn_t interrupt_hw(int irq, void *dev_id)
> return IRQ_NONE;
> }
>
> - if( 0 != (dev->ext)) {
> + if( NULL != (dev->ext)) {

At the risk of looking an idiot, I'm taking a liberty to ask what is
the point in explicit comparison to zero in conditional operators? Is
it not a fundamental C idiom to write

if (a) {
}

instead of

if (a != 0) {
}

and, similarly, to write

if (!a) {
}

instead of

if (a == 0) {
}

?

Thanks,

Dmitri