From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1760208AbYCCSyu@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760208AbYCCSyu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Mar 2008 13:54:50 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755196AbYCCSyl
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 3 Mar 2008 13:54:41 -0500
Received: from mx1.redhat.com ([66.187.233.31]:34375 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752106AbYCCSyk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Mar 2008 13:54:40 -0500
Message-ID: <47CC4948.7020307@redhat.com>
Date: Mon, 03 Mar 2008 13:54:00 -0500
From: Prarit Bhargava <prarit@redhat.com>
User-Agent: Thunderbird 2.0.0.12 (X11/20080213)
MIME-Version: 1.0
To: Jesse Barnes <jbarnes@virtuousgeek.org>
CC: Alex Chiang <achiang@hp.com>, Gary Hade <garyhade@us.ibm.com>,
       kaneshige.kenji@jp.fujitsu.com, warthog19@eaglescrag.net,
       Matthew Wilcox <matthew@wil.cx>, gregkh@suse.de,
       kristen.c.accardi@intel.com, rick.jones2@hp.com,
       linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
       linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/4] Remove path attribute from sgi_hotplug
References: <20080229002341.GA21420@ldl.fc.hp.com> <20080229002640.GB21420@ldl.fc.hp.com> <200803031048.20762.jbarnes@virtuousgeek.org>
In-Reply-To: <200803031048.20762.jbarnes@virtuousgeek.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>> -	bss_hotplug_slot->name = kmalloc(SN_SLOT_NAME_SIZE, GFP_KERNEL);
>> -	if (!bss_hotplug_slot->name) {
>> -		kfree(bss_hotplug_slot->private);
>> -		return -ENOMEM;
>> -	}
>> +	bss_hotplug_slot->name = slot->physical_path;
>>
>>  	slot->device_num = device;
>>  	slot->pci_bus = pci_bus;
>> -	sprintf(bss_hotplug_slot->name, "%04x:%02x:%02x",
>> -		pci_domain_nr(pci_bus),
>> -		((u16)pcibus_info->pbi_buscommon.bs_persist_busnum),
>> -		device + 1);
>>
>>     
>   
Ugh ... it has been a while since I've looked at or owned this code ;) 
-- but I do seem to recall that on SGI boxes the slot's name was 
different from the physical path of the device (ie, what was stamped on 
the back of the PCI hotplug chassis was different from Linux' PCI name) 
-- OTOH, I haven't recently looked at what slot->physical_path has been 
initialized to, so they might now be one-and-the-same ....

P.