Re: [PATCH 2.6.24] mm: BadRAM support for broken memory

Johannes Weiner
2008-03-11T19:26:53Z

Hi Jan-Simon,

Jan-Simon Möller <dl9pf@gmx.de> writes:

> Patches V3 with corrected Syntax, tnx hpa !
> Changed also text according to idea from Len.
>
> diff --git a/Documentation/kernel-parameters.txt
> b/Documentation/kernel-parameters.txt
> index 533e67f..f25da88 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -1131,6 +1131,10 @@ and is between 256 and 4096 characters. It is defined
> in the file
> memmap=nn[KMG]$ss[KMG]
> [KNL,ACPI] Mark specific memory as reserved.
> Region of memory to be used, from ss to ss+nn.
> + Example: Exclude memory from 0x18690000-0x1869ffff
> + memmap=64K$0x18690000
> + or
> + memmap=0x10000$0x18690000
>
> meye.*= [HW] Set MotionEye Camera parameters
> See Documentation/video4linux/meye.txt.
>
>
> Signed-off-by: Jan-Simon Moeller <dl9pf@gmx.de>

Would you mind formatting the patch as described in
Documentation/SubmittingPatches? That probably increases the chance of
getting it merged.

As far as your patch is concerned, I see broken whitespace, a changelog
entry and the signed-off-by is in the wrong place.

Hannes