From: Jiri Slaby <jirislaby@gmail.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Russell King <rmk@arm.linux.org.uk>, Andi Kleen <ak@suse.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [JANITOR-PATCH] rtc: switch to unlocked_ioctl
Date: Tue, 04 Mar 2008 23:58:01 +0100 [thread overview]
Message-ID: <47CDD3F9.7070801@gmail.com> (raw)
In-Reply-To: <1204664803.5698.27.camel@brick>
Harvey Harrison napsal(a):
> Make the lock/unlock_kernel explicit.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/arm/common/rtctime.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/common/rtctime.c b/arch/arm/common/rtctime.c
> index f53bca4..2062f92 100644
> --- a/arch/arm/common/rtctime.c
> +++ b/arch/arm/common/rtctime.c
> @@ -173,8 +173,7 @@ static unsigned int rtc_poll(struct file *file, poll_table *wait)
> return data != 0 ? POLLIN | POLLRDNORM : 0;
> }
>
> -static int rtc_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
> - unsigned long arg)
> +static int rtc_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
long? I guess you need to get a cross-compiler...
next prev parent reply other threads:[~2008-03-04 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 21:06 [JANITOR-PATCH] rtc: switch to unlocked_ioctl Harvey Harrison
2008-03-04 22:58 ` Jiri Slaby [this message]
2008-03-05 10:16 ` Andi Kleen
2008-03-06 8:16 ` Russell King
2008-03-06 8:19 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47CDD3F9.7070801@gmail.com \
--to=jirislaby@gmail.com \
--cc=ak@suse.de \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox