Re: [PATCH 1/1] export native versions of machine_ops functions

[Avi Kivity <avi@qumranet.com>]

Ingo Molnar wrote:
> * Glauber Costa <glommer@gmail.com> wrote:
>
>   
>>>  i'd like to do this only if there are actual users - otherwise 
>>>  we'll get a trickle of "make needlessly global functions static" 
>>>  patches a few weeks later ;-)
>>>       
>> KVM is a user for that. Because it registers a memory area in which 
>> the host will be continually writting to (the clock), when it 
>> shutdown, the host have no way to know it has to stop. If you're 
>> really shutting down, there's no problem. But if you're kexecing, for 
>> example, the host will keep writting to a random memory area after the 
>> new kernel installs.
>>     
>
> i mean, i agree in general - but KVM is not a user of any of those 
> currently static functions. So i've applied your patch but lets make 
> sure those functions really get used :)
>   

The user will be in my 2.6.26 queue.  Unfortunately it means a 
dependency between kvm.git and x86.git, again.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.