From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765499AbYCGEju (ORCPT ); Thu, 6 Mar 2008 23:39:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759439AbYCGEjh (ORCPT ); Thu, 6 Mar 2008 23:39:37 -0500 Received: from e28smtp05.in.ibm.com ([59.145.155.5]:56049 "EHLO e28esmtp05.in.ibm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1764473AbYCGEjg (ORCPT ); Thu, 6 Mar 2008 23:39:36 -0500 Message-ID: <47D0C697.3080602@linux.vnet.ibm.com> Date: Fri, 07 Mar 2008 10:07:43 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Li Zefan CC: Randy Dunlap , Paul Menage , Andrew Morton , Pavel Emelianov , Hugh Dickins , Sudhir Kumar , YAMAMOTO Takashi , linux-kernel@vger.kernel.org, taka@valinux.co.jp, linux-mm@kvack.org, David Rientjes , KAMEZAWA Hiroyuki Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot time References: <20080306185952.23290.49571.sendpatchset@localhost.localdomain> <20080306111145.27efc74c.randy.dunlap@oracle.com> <47D086D3.20205@cn.fujitsu.com> In-Reply-To: <47D086D3.20205@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Li Zefan wrote: > Randy Dunlap wrote: >> On Fri, 07 Mar 2008 00:29:52 +0530 Balbir Singh wrote: >> >>> From: Paul Menage >>> >>> The effects of cgroup_disable=foo are: >>> >>> - foo doesn't show up in /proc/cgroups >>> - foo isn't auto-mounted if you mount all cgroups in a single hierarchy >>> - foo isn't visible as an individually mountable subsystem >>> >>> As a result there will only ever be one call to foo->create(), at init >>> time; all processes will stay in this group, and the group will never >>> be mounted on a visible hierarchy. Any additional effects (e.g. not >>> allocating metadata) are up to the foo subsystem. >>> >>> This doesn't handle early_init subsystems (their "disabled" bit isn't >>> set be, but it could easily be extended to do so if any of the >>> early_init >>> systems wanted it - I think it would just involve some nastier parameter >>> processing since it would occur before the command-line argument parser >>> had been run. >>> >>> [Balbir added Documentation/kernel-parameters updates] >>> >>> Signed-off-by: Paul Menage >>> Signed-off-by: Balbir Singh >>> --- >>> >>> Documentation/kernel-parameters.txt | 4 ++++ >>> include/linux/cgroup.h | 1 + >>> kernel/cgroup.c | 27 +++++++++++++++++++++++++-- >>> 3 files changed, 30 insertions(+), 2 deletions(-) >>> >>> diff -puN Documentation/kernel-parameters.txt~cgroup_disable >>> Documentation/kernel-parameters.txt >>> --- >>> linux-2.6.25-rc4/Documentation/kernel-parameters.txt~cgroup_disable >>> 2008-03-06 17:57:32.000000000 +0530 >>> +++ linux-2.6.25-rc4-balbir/Documentation/kernel-parameters.txt >>> 2008-03-06 18:00:32.000000000 +0530 >>> @@ -383,6 +383,10 @@ and is between 256 and 4096 characters. >>> ccw_timeout_log [S390] >>> See Documentation/s390/CommonIO for details. >>> >>> + cgroup_disable= [KNL] Enable disable a particular controller >> >> So it can enable or disable? or the text has extra text? >> > > don't think so, should be "Disable a particular controller" > Agreed and fixed. Thanks, -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL