Re: [PATCH 5/9] Make use of permissions, returned by kobj_lookup

Greg KH
2008-03-11T17:55:26Z

On Tue, Mar 11, 2008 at 12:57:55PM +0300, Pavel Emelyanov wrote:
>
> Besides, I've measured some things - the lat_syscall test for open from
> lmbench test suite and the nptl perf test. Here are the results:
>
> sec nosec
> open 3.0980s 3.0709s
> nptl 2.7746s 2.7710s
>
> So we have 0.88% loss in open and ~0.15% with nptl. I know, this is not that
> much, but it is noticeable. Besides, this is only two tests, digging deeper
> may reveal more.

I think that is in the noise of sampling if you run that test many more
times.

> Let alone the fact that simply turning the CONFIG_SECURITY to 'y' puts +8Kb
> to the vmlinux...
>
> I think, I finally agree with you and Al Viro, that the kobj mapper is
> not the right place to put the filtering, but taking the above numbers
> into account, can we put the "hooks" into the #else /* CONFIG_SECURITY */
> versions of security_inode_permission/security_file_permission/etc?

Ask the security module interface maintainers about this, not me :)

good luck,

greg k-h