Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)

Paul Menage
2008-03-07T09:30:17Z

On Fri, Mar 7, 2008 at 12:57 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
> This doesn't handle early_init subsystems (their "disabled" bit isn't
> set be,

I think you meant something like

(their "disabled" bit isn't set before their initial "create" call is made)

> +static int __init cgroup_disable(char *str)
> +{
> + int i;
> +
> + while (*str) {
> + for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> + struct cgroup_subsys *ss = subsys[i];
> +
> + if (!strncmp(str, ss->name, strlen(ss->name))) {
> + ss->disabled = 1;
> + printk(KERN_INFO "Disabling %s control group"
> + " subsystem\n", ss->name);
> + break;

Doesn't this mean that cgroup_disable=cpu will disable whichever comes
first out of cpuset, cpuacct or cpu in the subsystem list?

I suggest just sticking with the original simpler version that
required separate cgroup_disabled=foo options for each system that you
want to disable.

Paul