Re: [PATCH] Add cgroup support for enabling controllers at boot time (v2)

Balbir Singh
2008-03-07T13:31:06Z

Paul Menage wrote:
> On Fri, Mar 7, 2008 at 4:58 AM, Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>> > Or rather, it's the other way around - cgroup_disable=cpuset will
>> > instead disable the "cpu" subsystem if "cpu" comes before "cpuset" in
>> > the subsystem list.
>> >
>>
>> Would it? I must be missing something, since we do a strncmp with ss->name.
>> I would expect that to match whole strings.
>>
>
> No, strncmp only checks the first n characters - so in that case,
> you'd be checking for !strncmp("cpuset", "cpu", 3), which will return
> true

Aaah.. I see the problem now.

--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL