From: Roel Kluin <12o3l@tiscali.nl>
To: ego@in.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Dhaval Giani <dhaval@linux.vnet.ibm.com>
Subject: Re: [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus
Date: Mon, 10 Mar 2008 16:32:45 +0100 [thread overview]
Message-ID: <47D5549D.8090402@tiscali.nl> (raw)
In-Reply-To: <20080310125414.GE17646@in.ibm.com>
Gautham R Shenoy wrote:
> On Mon, Mar 10, 2008 at 01:24:18PM +0100, Ingo Molnar wrote:
>> * Gautham R Shenoy <ego@in.ibm.com> wrote:
>>
>>> x86: Don't send RESCHEDULE_VECTOR to offlined cpus.
>>> From: Gautham R Shenoy <ego@in.ibm.com>
>>>
>>> In the x86 native_smp_send_reschedule_function(), don't send the IPI
>>> if the cpu has gone offline already. Warn nevertheless!!
>> have you seen this happen?
>
> Yup, this afternoon while running
> cpu-hotplug stress tests (http://lkml.org/lkml/2008/3/3/11)
> in parallel with kern-bench, I got this on the serial console.
from arch/m32r/kernel/smp.c:134
void smp_send_reschedule(int cpu_id)
{
WARN_ON(cpu_is_offline(cpu_id));
send_IPI_mask(cpumask_of_cpu(cpu_id), RESCHEDULE_IPI, 1);
}
should this be changed as well?
next prev parent reply other threads:[~2008-03-10 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 12:14 [PATCH] x86: Don't send RESCHEDULE_VECTOR to offlined cpus Gautham R Shenoy
2008-03-10 12:24 ` Ingo Molnar
2008-03-10 12:54 ` Gautham R Shenoy
2008-03-10 15:32 ` Roel Kluin [this message]
2008-03-10 16:36 ` Gregory Haskins
2008-03-11 9:21 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5549D.8090402@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox