Re: [PATCH] RUSAGE_THREAD

[Michael Kerrisk <mtk.manpages@googlemail.com>]

Sripathi Kodi wrote:
> On Friday 22 February 2008 23:13, Michael Kerrisk wrote:
>> Sripathi Kodi wrote:
>>> Hi Andrew,
>>>
>>> This adds the RUSAGE_THREAD option for the getrusage system call.
>>> This is essentially Roland's patch from
>>> http://lkml.org/lkml/2008/1/18/589, but the line about RUSAGE_LWP
>>> line has been removed, as suggested by Ulrich and Christoph.
>>>
>>> Thanks,
>>> Sripathi.
>>>
>>> This adds the RUSAGE_THREAD option for the getrusage system call.
>> Sripathi,
>>
>> Could you write some small piece of text for the getrusage.2 man page
>> that describes the intended behavior of RUSAGE_THREAD?
> 
> Michael,
> 
> Please take a look at the following patch to getrusage.2. This is the first
> time I have edited a manpage, so I hope I have done it correctly!
> 
> Also, the RUSAGE_THREAD patch is currently in -mm, but not in mainline
> yet. Hoping that it will make it, I have put a line in the patch that it is 
> supported from 2.6.25 onwards.

Sripathi,

Thanks for the patch -- looks reasonable to me.

I see that RUSAGE_THREAD didin't make the cut for 2.6.25.  If you remember,
could you ping me when it does hit mainline.

Cheers,

Michael


> PS: I fixed spelling error in Ulrich's mail id in the CC list.
> 
> Signed-off-by: Sripathi Kodi <sripathik@in.ibm.com>
> 
> --- getrusage.2.org	2008-02-27 17:00:57.000000000 +0530
> +++ getrusage.2	2008-02-27 17:01:28.000000000 +0530
> @@ -44,12 +44,22 @@ getrusage \- get resource usage
>  .PP
>  .BR getrusage ()
>  returns current resource usages, for a \fIwho\fP
> -of either 
> +of 
> +.B RUSAGE_THREAD, 
>  .B RUSAGE_SELF
>  or 
>  .BR RUSAGE_CHILDREN .
> -The former asks for resources used by the current process,
> -the latter for resources used by those of its children
> +.PP
> +.B RUSAGE_THREAD 
> +asks for resources used by the calling thread.
> +.PP
> +.B RUSAGE_SELF 
> +asks for resources used by the current process, 
> +which is the sum of resources used by all threads
> +in the process.
> +.PP
> +.B RUSAGE_CHILDREN 
> +asks for resources used by those of its children
>  that have terminated and have been waited for.
>  .PP 
>  .in +0.5i
> @@ -130,6 +140,9 @@ Since Linux 2.6, 
>  and
>  .I ru_nivcsw
>  are also maintained.
> +.PP
> +.B RUSAGE_THREAD
> +is supported only in Linux kernel versions 2.6.25 and above.
>  .SH "SEE ALSO"
>  .BR getrlimit (2),
>  .BR times (2),
> 

-- 
Michael Kerrisk
Maintainer of the Linux man-pages project
http://www.kernel.org/doc/man-pages/
Want to report a man-pages bug?  Look here:
http://www.kernel.org/doc/man-pages/reporting_bugs.html