From: Li Zefan <lizf@cn.fujitsu.com>
To: Paul Menage <menage@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cgroup: switch to proc_create()
Date: Tue, 11 Mar 2008 08:43:18 +0900 [thread overview]
Message-ID: <47D5C796.1080302@cn.fujitsu.com> (raw)
In-Reply-To: <6599ad830803101401s3b12bc85l53ef67f083ad761c@mail.gmail.com>
Paul Menage wrote:
> On Mon, Mar 10, 2008 at 12:30 AM, Li Zefan <lizf@cn.fujitsu.com> wrote:
>> There is a race between create_proc_entry() and the assignment
>> of file ops. proc_create() is invented to fix it.
>>
>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>
> Acked-by: Paul Menage <menage@google.com>
>
> Doesn't seem to be a serious race since there's nothing in userspace
> at this point to read the file. But replacing four lines with one is
> generally a good thing.
>
Yes I know, it's a slight race in case of modular code, but the aim is
to replace all the use of create_proc_entry() with proc_create(). :)
> Paul
>
prev parent reply other threads:[~2008-03-10 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-10 7:30 [PATCH 2/2] cgroup: switch to proc_create() Li Zefan
2008-03-10 21:01 ` Paul Menage
2008-03-10 23:43 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47D5C796.1080302@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox