public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Schuster <olivers137@aol.com>
To: linux-kernel@vger.kernel.org
Cc: win@iguana.be
Subject: Re: [WATCHDOG] v2.5.25-rc patches
Date: Tue, 11 Mar 2008 14:21:16 +0100	[thread overview]
Message-ID: <47D6874C.8050404@aol.com> (raw)

Hi,

WARNING

this patch can cause serious problems in the case, that someone use it with an it8712 rev. 8 and above.

You patch it8712f_wdt.c in function it8712f_wdt_update_margin(void):
...
+	if (revision >= 0x08)
+		superio_outw(units, WDT_TIMEOUT);
+	else
+		superio_outb(units, WDT_TIMEOUT);

but here you can't use superio_outw, because the bytes are swaped -- historical reason.
I suggest to substitute 
	superio_outw(units, WDT_TIMEOUT);
with
	superio_outb(units >> 8, WDT_TIMEOUT + 1);
	superio_outb(units, WDT_TIMEOUT);

or to change the patch with (only the referenced position above)

+	if (revision >= 0x08)
+		superio_outb(units >> 8, WDT_TIMEOUT + 1);
+
+	superio_outb(units, WDT_TIMEOUT);

Regards,
Oliver


             reply	other threads:[~2008-03-11 13:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 13:21 Oliver Schuster [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-03-10 20:14 [WATCHDOG] v2.5.25-rc patches Wim Van Sebroeck
2008-03-11 18:14 ` Oliver Schuster
2008-03-11 21:02   ` Wim Van Sebroeck
2008-02-19 12:24 Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47D6874C.8050404@aol.com \
    --to=olivers137@aol.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=win@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox