Re: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5: Reported regressions from 2.6.24)

Greg KH
2008-03-12T22:54:50Z

On Wed, Mar 12, 2008 at 03:25:41PM -0700, Linus Torvalds wrote:
>
>
> On Wed, 12 Mar 2008, Greg KH wrote:
> >
> > Actually, here's a simple patch from -next that should test this logic
> > for you. Can you let me know if this solves the start up WARNING dump
> > for you?
>
> This patch looks bogus.
>
> Why do you introduce a "dev->is_added" field that apparently has to match
> the old "list_empty(&dev->global_list)" 1:1 anyway?
>
> In other words: when is it *ever* permissible for "is_added" to have a
> different value from the "list_empty(..)" logic? And if they must always
> match (and it looks like they have to, since you set and clear the flag
> exactly when you add/remove it from the list), then what exactly is this
> supposed to fix?

In the patch series in -next, it is supposed to replace the list_empty()
logic exactly, as that list goes away in the next patch in the series.

So yes, it is not a "fix" per-say, but would be nice to see if it solves
this issue in some way.

All I can think is that somehow this pci device for the root hub isn't
added to that extra list (as that is only done in the pcibios logic) and
so it isn't set.

I can't get a box here to produce both of those PCI: messages myself,
and neither can Len, so something is really odd here. And that has
nothing to do with the pci_bus rework, that is just showing the problem
more accuratly now. Even if it were to be reverted, the root problem
would still be present.

thanks,

greg k-h