public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel/sched.c: remove double unlikely
@ 2008-03-13 16:41 Roel Kluin
  2008-03-21 11:35 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2008-03-13 16:41 UTC (permalink / raw)
  To: Ingo Molnar, rml; +Cc: lkml

Combine two unlikely's

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/kernel/sched.c b/kernel/sched.c
index 1cb53fb..532a7f4 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3875,7 +3875,7 @@ need_resched_nonpreemptible:
 
 	if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
 		if (unlikely((prev->state & TASK_INTERRUPTIBLE) &&
-				unlikely(signal_pending(prev)))) {
+				signal_pending(prev))) {
 			prev->state = TASK_RUNNING;
 		} else {
 			deactivate_task(rq, prev, 1);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kernel/sched.c: remove double unlikely
  2008-03-13 16:41 [PATCH] kernel/sched.c: remove double unlikely Roel Kluin
@ 2008-03-21 11:35 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-03-21 11:35 UTC (permalink / raw)
  To: Roel Kluin; +Cc: rml, lkml


* Roel Kluin <12o3l@tiscali.nl> wrote:

> Combine two unlikely's

> -				unlikely(signal_pending(prev)))) {
> +				signal_pending(prev))) {

good catch - thanks, applied.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-03-21 11:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-13 16:41 [PATCH] kernel/sched.c: remove double unlikely Roel Kluin
2008-03-21 11:35 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox