* [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver
@ 2008-03-14 19:36 Carlos Aguiar
2008-03-24 12:07 ` Pierre Ossman
2008-03-25 9:58 ` Felipe Balbi
0 siblings, 2 replies; 4+ messages in thread
From: Carlos Aguiar @ 2008-03-14 19:36 UTC (permalink / raw)
To: Pierre Ossman; +Cc: Tony Lindgren, linux-kernel
From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
This patch removes some opcodes from host driver so there's no need on putting
'#include <linux/mmc/mmc.h>', that should not be needed in host drivers.
Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
---
drivers/mmc/host/omap.c | 11 +++--------
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index c9dfeb1..eb7175a 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -495,15 +495,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
if (status & OMAP_MMC_STAT_CMD_TOUT) {
/* Timeouts are routine with some commands */
if (host->cmd) {
- if (host->cmd->opcode != MMC_ALL_SEND_CID &&
- host->cmd->opcode !=
- MMC_SEND_OP_COND &&
- host->cmd->opcode !=
- MMC_APP_CMD &&
- !mmc_omap_cover_is_open(host))
+ if (!mmc_omap_cover_is_open(host))
dev_err(mmc_dev(host->mmc),
- "command timeout, CMD %d\n",
- host->cmd->opcode);
+ "command timeout, CMD %d\n",
+ host->cmd->opcode);
host->cmd->error = -ETIMEDOUT;
end_command = 1;
}
-- 1.5.3.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver
2008-03-14 19:36 [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver Carlos Aguiar
@ 2008-03-24 12:07 ` Pierre Ossman
2008-03-25 9:58 ` Felipe Balbi
1 sibling, 0 replies; 4+ messages in thread
From: Pierre Ossman @ 2008-03-24 12:07 UTC (permalink / raw)
To: Carlos Aguiar; +Cc: Tony Lindgren, linux-kernel
On Fri, 14 Mar 2008 15:36:01 -0400
Carlos Aguiar <carlos.aguiar@indt.org.br> wrote:
> From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
>
> This patch removes some opcodes from host driver so there's no need on putting
> '#include <linux/mmc/mmc.h>', that should not be needed in host drivers.
>
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> ---
Looks good.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver
2008-03-14 19:36 [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver Carlos Aguiar
2008-03-24 12:07 ` Pierre Ossman
@ 2008-03-25 9:58 ` Felipe Balbi
1 sibling, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2008-03-25 9:58 UTC (permalink / raw)
To: Carlos Aguiar; +Cc: Pierre Ossman, Tony Lindgren, linux-kernel
On Fri, Mar 14, 2008 at 9:36 PM, Carlos Aguiar
<carlos.aguiar@indt.org.br> wrote:
> From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
>
> This patch removes some opcodes from host driver so there's no need on putting
> '#include <linux/mmc/mmc.h>', that should not be needed in host drivers.
>
You should update this patch and remove the '#include
<linux/mmc/mmc.h>' from omap.c
> Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
> ---
> drivers/mmc/host/omap.c | 11 +++--------
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
> index c9dfeb1..eb7175a 100644
> --- a/drivers/mmc/host/omap.c
> +++ b/drivers/mmc/host/omap.c
> @@ -495,15 +495,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
> if (status & OMAP_MMC_STAT_CMD_TOUT) {
> /* Timeouts are routine with some commands */
> if (host->cmd) {
> - if (host->cmd->opcode != MMC_ALL_SEND_CID &&
> - host->cmd->opcode !=
> - MMC_SEND_OP_COND &&
> - host->cmd->opcode !=
> - MMC_APP_CMD &&
> - !mmc_omap_cover_is_open(host))
> + if (!mmc_omap_cover_is_open(host))
> dev_err(mmc_dev(host->mmc),
> - "command timeout, CMD %d\n",
> - host->cmd->opcode);
> + "command timeout, CMD %d\n",
> + host->cmd->opcode);
> host->cmd->error = -ETIMEDOUT;
> end_command = 1;
> }
> -- 1.5.3.GIT
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Best Regards,
Felipe Balbi
felipebalbi@users.sourceforge.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver
2008-03-24 12:26 ` Pierre Ossman
@ 2008-03-26 20:08 ` Carlos Aguiar
0 siblings, 0 replies; 4+ messages in thread
From: Carlos Aguiar @ 2008-03-26 20:08 UTC (permalink / raw)
To: ext Pierre Ossman; +Cc: Tony Lindgren, linux-kernel
From: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
This patch removes some opcodes from host driver so there's no need on putting
'#include <linux/mmc/mmc.h>', that should not be needed in host drivers.
Signed-off-by: Carlos Eduardo Aguiar <carlos.aguiar@indt.org.br>
---
drivers/mmc/host/omap.c | 11 +++--------
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index c9dfeb1..eb7175a 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -495,15 +495,10 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id)
if (status & OMAP_MMC_STAT_CMD_TOUT) {
/* Timeouts are routine with some commands */
if (host->cmd) {
- if (host->cmd->opcode != MMC_ALL_SEND_CID &&
- host->cmd->opcode !=
- MMC_SEND_OP_COND &&
- host->cmd->opcode !=
- MMC_APP_CMD &&
- !mmc_omap_cover_is_open(host))
+ if (!mmc_omap_cover_is_open(host))
dev_err(mmc_dev(host->mmc),
- "command timeout, CMD %d\n",
- host->cmd->opcode);
+ "command timeout, CMD %d\n",
+ host->cmd->opcode);
host->cmd->error = -ETIMEDOUT;
end_command = 1;
}
-- 1.5.3.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-03-26 20:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-14 19:36 [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver Carlos Aguiar
2008-03-24 12:07 ` Pierre Ossman
2008-03-25 9:58 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-03-14 19:35 [PATCH 00/18] MMC: OMAP: Sync MMC OMAP driver with mainline tree Carlos Aguiar
2008-03-24 12:26 ` Pierre Ossman
2008-03-26 20:08 ` [PATCH 01/18] MMC: OMAP: Remove some opcodes from host driver Carlos Aguiar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox