From: Eric Sandeen <sandeen@sandeen.net>
To: David Miller <davem@davemloft.net>
Cc: hch@infradead.org, andi@firstfloor.org, byron.bbradley@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: XFS Fails Quality Assurance Tests on ARM
Date: Mon, 17 Mar 2008 22:41:47 -0500 [thread overview]
Message-ID: <47DF39FB.7060306@sandeen.net> (raw)
In-Reply-To: <20071030.143834.127458535.davem@davemloft.net>
David Miller wrote:
> From: Christoph Hellwig <hch@infradead.org>
> Date: Tue, 30 Oct 2007 17:54:18 +0000
>
>> On Tue, Oct 30, 2007 at 12:47:35AM -0500, Eric Sandeen wrote:
>>> There was a patch floating around to "fix" it but it's not on-disk
>>> compatible w/ x86 & friends, it just makes things consistent for arm. I
>>> think packing some of these structures would take care of it, but this
>>> problem could use some attention & testing I think, it's been floating
>>> around a long time.
>> Do you have a pointer to that patch? Once the unaliged fields are
>> identified simply using get_unaligned on them should fix this issue.
>
> True, but there is the tertiary issue that the packing done by these
> platforms might mean that the on-disk format is different on different
> platforms which the XFS folks likely want to avoid if possible.
Right.
FWIW, this patch should fix up at least the most egregious problems, and
in fact I think most likely resolves the whole issue with the old arm
ABI, though for some reason, qemu issues keep me from getting a whole
xfstests QA run to complete....
http://oss.sgi.com/archives/xfs/2008-03/msg00151.html
-Eric
prev parent reply other threads:[~2008-03-18 3:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 3:12 XFS Fails Quality Assurance Tests on ARM Byron Bradley
2007-08-31 4:39 ` David Miller
2007-09-01 22:14 ` Andi Kleen
2007-09-27 21:40 ` Nick Piggin
2007-10-02 7:38 ` David Chinner
2007-10-30 5:47 ` Eric Sandeen
2007-10-30 17:54 ` Christoph Hellwig
2007-10-30 18:14 ` Eric Sandeen
2007-10-30 21:38 ` David Miller
2008-03-18 3:41 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DF39FB.7060306@sandeen.net \
--to=sandeen@sandeen.net \
--cc=andi@firstfloor.org \
--cc=byron.bbradley@gmail.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox