From: Masami Hiramatsu <mhiramat@redhat.com>
To: Yakov Lerner <iler.ml@gmail.com>
Cc: prasanna@in.ibm.com, ananth@in.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kprobes: correct regs->ip value in post_hander()
Date: Tue, 18 Mar 2008 11:26:22 -0400 [thread overview]
Message-ID: <47DFDF1E.7000600@redhat.com> (raw)
In-Reply-To: <1205850409-12914-1-git-send-email-iler.ml@gmail.com>
Yakov Lerner wrote:
> From: "Yakov Lerner" <iler.ml@gmail.com>
>
> This patch corrects the value of regs->ip in post_handler(). Prior to
> this patch, post_handler() was given address meaningless to the user in
> regs->ip. The expected value is address of the next instruction to be
> executed after kprobed instruction. This patch simply swaps the order of
> post_handler() and resume_execution(). post_handler() now sees the
> corrected, expected value in regs->ip. post_handler() is now called after
> after resume_execution(), not before.
>
> Only x86 platform was tested. Arm arch needs no changes.
>
> Signed-off-by: Yakov Lerner <iler.ml@gmail.com>
Thank you, I tested this on x86-64/x86/ia64.
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next parent reply other threads:[~2008-03-19 23:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a8vQD-6wm-3@gated-at.bofh.it>
[not found] ` <1205850409-12914-1-git-send-email-iler.ml@gmail.com>
2008-03-18 15:26 ` Masami Hiramatsu [this message]
2008-03-18 15:56 ` [PATCH] kprobes: correct regs->ip value in post_hander() Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47DFDF1E.7000600@redhat.com \
--to=mhiramat@redhat.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=iler.ml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox