* Re: [PATCH] kprobes: correct regs->ip value in post_hander() [not found] ` <1205850409-12914-1-git-send-email-iler.ml@gmail.com> @ 2008-03-18 15:26 ` Masami Hiramatsu 2008-03-18 15:56 ` Ananth N Mavinakayanahalli 1 sibling, 0 replies; 2+ messages in thread From: Masami Hiramatsu @ 2008-03-18 15:26 UTC (permalink / raw) To: Yakov Lerner; +Cc: prasanna, ananth, anil.s.keshavamurthy, davem, linux-kernel Yakov Lerner wrote: > From: "Yakov Lerner" <iler.ml@gmail.com> > > This patch corrects the value of regs->ip in post_handler(). Prior to > this patch, post_handler() was given address meaningless to the user in > regs->ip. The expected value is address of the next instruction to be > executed after kprobed instruction. This patch simply swaps the order of > post_handler() and resume_execution(). post_handler() now sees the > corrected, expected value in regs->ip. post_handler() is now called after > after resume_execution(), not before. > > Only x86 platform was tested. Arm arch needs no changes. > > Signed-off-by: Yakov Lerner <iler.ml@gmail.com> Thank you, I tested this on x86-64/x86/ia64. Acked-by: Masami Hiramatsu <mhiramat@redhat.com> -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kprobes: correct regs->ip value in post_hander() [not found] ` <1205850409-12914-1-git-send-email-iler.ml@gmail.com> 2008-03-18 15:26 ` [PATCH] kprobes: correct regs->ip value in post_hander() Masami Hiramatsu @ 2008-03-18 15:56 ` Ananth N Mavinakayanahalli 1 sibling, 0 replies; 2+ messages in thread From: Ananth N Mavinakayanahalli @ 2008-03-18 15:56 UTC (permalink / raw) To: Yakov Lerner Cc: mhiramat, prasanna, anil.s.keshavamurthy, davem, linux-kernel On Tue, Mar 18, 2008 at 09:26:49AM -0500, Yakov Lerner wrote: > From: "Yakov Lerner" <iler.ml@gmail.com> > > This patch corrects the value of regs->ip in post_handler(). Prior to > this patch, post_handler() was given address meaningless to the user in > regs->ip. The expected value is address of the next instruction to be > executed after kprobed instruction. This patch simply swaps the order of > post_handler() and resume_execution(). post_handler() now sees the > corrected, expected value in regs->ip. post_handler() is now called after > after resume_execution(), not before. > > Only x86 platform was tested. Arm arch needs no changes. > > Signed-off-by: Yakov Lerner <iler.ml@gmail.com> Tested on powerpc. Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Thanks Yakov! ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-19 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <a8vQD-6wm-3@gated-at.bofh.it>
[not found] ` <1205850409-12914-1-git-send-email-iler.ml@gmail.com>
2008-03-18 15:26 ` [PATCH] kprobes: correct regs->ip value in post_hander() Masami Hiramatsu
2008-03-18 15:56 ` Ananth N Mavinakayanahalli
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox