From: "Artem S. Tashkinov" <birdie@permonline.ru>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: GIT commit description flag(s)
Date: Wed, 19 Mar 2008 10:06:27 +0500 [thread overview]
Message-ID: <47E09F53.5020201@permonline.ru> (raw)
In-Reply-To: <alpine.LNX.1.00.0803181757020.8851@fbirervta.pbzchgretzou.qr>
I quite agree with you that the description is already there, but such
flags could help easily review or grep commits in order to identify your
areas of interest.
Even your example has ambiguity: "Wire up new timerfd syscalls" - It's
not easy to understand whether this particular commit is a bugfix, or it
speeds up things, or the old code which has been cleaned up, etc.
Jan Engelhardt wrote:
>
> On Mar 16 2008 02:35, Artem S. Tashkinov wrote:
>> It would be nice if [kernel] git commits had a flag [a char] (or a
>> combination of) describing their main purpose which could be the
>> following:
>>
>> bug Fix [F]
>> Speed up/Performance [S]
>> Revert [R]
>> New functionality [N]
>
> Usually you already give the type implicitly in the commit:
>
> dfd347f... HID: fix comment in hid_input_report()
> fa331ff... [S390] sclp_vt220: speed up console output for interactive work
> d9452e9... [NETPOLL]: Revert two bogus cleanups that broke netconsole.
> 8727e28... m68k{,nommu}: Wire up new timerfd syscalls
> b863ceb... [NET]: Add macvlan driver
>
> So all is well.
>
next prev parent reply other threads:[~2008-03-19 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-15 21:35 GIT commit description flag(s) Artem S. Tashkinov
2008-03-16 10:09 ` Johannes Weiner
2008-03-18 16:58 ` Jan Engelhardt
2008-03-19 5:06 ` Artem S. Tashkinov [this message]
2008-03-20 11:06 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E09F53.5020201@permonline.ru \
--to=birdie@permonline.ru \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox