From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Alex Chiang <achiang@hp.com>, Greg KH <gregkh@suse.de>
Cc: Gary Hade <garyhade@us.ibm.com>,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>,
Matthew Wilcox <matthew@wil.cx>,
warthog19@eaglescrag.net, rick.jones2@hp.com,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
linux-acpi@vger.kernel.org
Subject: [PATCH 4/16][BUG] PCI slot: Add missing semaphore for slot release (Not for mainline!)
Date: Fri, 21 Mar 2008 13:12:27 +0900 [thread overview]
Message-ID: <47E335AB.6020709@jp.fujitsu.com> (raw)
In-Reply-To: <47E33472.1000602@jp.fujitsu.com>
Add missing pci_bus sem into pci_destroy_slot(). There is possible
race condition because current code doesn't have any serialization
in the destroy path.
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
drivers/pci/slot.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.25-rc6/drivers/pci/slot.c
===================================================================
--- linux-2.6.25-rc6.orig/drivers/pci/slot.c
+++ linux-2.6.25-rc6/drivers/pci/slot.c
@@ -196,7 +196,9 @@ EXPORT_SYMBOL_GPL(pci_create_slot);
int pci_destroy_slot(struct pci_slot *slot)
{
+ down_write(&pci_bus_sem);
kobject_put(&slot->kobj);
+ up_write(&pci_bus_sem);
dbg("%s: decreased refcount to %d on %x:%d\n", __func__,
slot->kobj.kref.refcount, slot->bus->number, slot->number);
next prev parent reply other threads:[~2008-03-21 4:14 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 21:05 [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects Alex Chiang
2008-03-18 21:08 ` [PATCH 1/3] Construct one fakephp slot per pci slot Alex Chiang
2008-03-18 21:09 ` [PATCH 2/3] Introduce pci_slot Alex Chiang
2008-03-18 21:09 ` [PATCH 3/3] ACPI PCI slot detection driver Alex Chiang
2008-03-19 0:55 ` [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects Matthew Wilcox
2008-03-19 1:52 ` Alex Chiang
2008-03-19 2:34 ` Kenji Kaneshige
2008-03-19 2:24 ` Kenji Kaneshige
2008-03-21 4:07 ` Kenji Kaneshige
2008-03-21 4:09 ` [PATCH 1/16][BUG] Export kobject_rename for pci_hotplug_core (Not for mainline!) Kenji Kaneshige
2008-03-21 15:56 ` Alex Chiang
2008-03-21 16:15 ` Greg KH
2008-03-21 16:45 ` Alex Chiang
2008-03-21 4:10 ` [PATCH 2/16] ACPI pci_slot: Fix dmi table for Fujitsu PRIMEQUEST " Kenji Kaneshige
2008-03-21 16:04 ` Alex Chiang
2008-03-21 4:11 ` [PATCH 3/16][BUG] ACPI pci_slot: Fix _STA evaluation " Kenji Kaneshige
2008-03-21 16:17 ` Alex Chiang
2008-03-21 4:12 ` Kenji Kaneshige [this message]
2008-03-21 16:57 ` [PATCH 4/16][BUG] PCI slot: Add missing semaphore for slot release " Alex Chiang
2008-03-21 4:13 ` [PATCH 5/16] PCI slot: Use list_head for pci slot list " Kenji Kaneshige
2008-03-21 18:40 ` Alex Chiang
2008-03-21 4:14 ` [PATCH 6/16][BUG] ACPI pci_slot: Fix slot removal path " Kenji Kaneshige
2008-03-21 19:42 ` Alex Chiang
2008-03-21 4:14 ` [PATCH 7/16][BUG] PCI slot: Remove compiler warnings " Kenji Kaneshige
2008-03-21 20:01 ` Alex Chiang
2008-03-21 4:15 ` [PATCH 8/16][BUG] PCI slot: Fix invalid memory access " Kenji Kaneshige
2008-03-21 20:01 ` Alex Chiang
2008-03-21 4:16 ` [PATCH 9/16] PCI slot: Remove unused slot member from pci_dev " Kenji Kaneshige
2008-03-21 19:30 ` Matthew Wilcox
2008-03-24 20:29 ` Alex Chiang
2008-03-21 4:17 ` [PATCH 10/16] PCI slot: Replace dbg with pr_debug " Kenji Kaneshige
2008-03-21 19:30 ` Matthew Wilcox
2008-03-21 20:02 ` Alex Chiang
2008-03-21 4:18 ` [PATCH 11/16] PCI slot: Remove useless release handler " Kenji Kaneshige
2008-03-25 3:08 ` Alex Chiang
2008-03-21 4:19 ` [PATCH 12/16] PCI slot: Use .default_attrs for address file " Kenji Kaneshige
2008-03-21 19:32 ` Matthew Wilcox
2008-03-25 3:31 ` Alex Chiang
2008-03-21 4:23 ` [PATCH 13/16] PCI slot: Fix return value of pci_create_slot() " Kenji Kaneshige
2008-03-25 3:31 ` Alex Chiang
2008-03-21 4:26 ` [PATCH 14/16] PCI slot: Change return value of pci_destroy_slot() " Kenji Kaneshige
2008-03-21 19:32 ` Matthew Wilcox
2008-03-25 3:31 ` Alex Chiang
2008-03-21 4:26 ` [PATCH 15/16] PCI slot: Trivial cleanups for slot.c " Kenji Kaneshige
2008-03-21 19:33 ` Matthew Wilcox
2008-03-25 3:31 ` Alex Chiang
2008-03-21 4:27 ` [PATCH 16/16][BUG] PCI hotplug core: add missing lock for hotplug slot list " Kenji Kaneshige
2008-03-25 3:31 ` Alex Chiang
2008-03-21 15:53 ` [PATCH 0/3, v10] PCI, ACPI: Physical PCI slot objects Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E335AB.6020709@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=achiang@hp.com \
--cc=garyhade@us.ibm.com \
--cc=gregkh@suse.de \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
--cc=rick.jones2@hp.com \
--cc=warthog19@eaglescrag.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox