* Commit 270637abff0cdf848b910b9f96ad342e1da61c66 introduced a lot new compiler warnings
@ 2008-03-21 19:11 Gabriel C
2008-03-21 22:43 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gabriel C @ 2008-03-21 19:11 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Vlad Yasevich, Sridhar Samudrala, David S. Miller
Hi all ,
I noticed the following new compile warnings on current git head introduced by 270637abff0cdf848b910b9f96ad342e1da61c66 :
In file included from net/sctp/sm_statetable.c:50:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/sm_statefuns.c:62:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/protocol.c:60:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/sm_sideeffect.c:55:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/endpointola.c:55:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/associola.c:59:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/transport.c:53:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/chunk.c:46:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/sm_make_chunk.c:65:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/ulpevent.c:49:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/inqueue.c:46:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/outqueue.c:55:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/ulpqueue.c:48:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/command.c:42:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/tsnmap.c:46:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/bind_addr.c:50:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/socket.c:79:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/primitive.c:54:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/output.c:61:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/input.c:61:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/debug.c:48:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/ssnmap.c:40:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/proc.c:40:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/auth.c:40:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/sysctl.c:45:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
Regards,
Gabriel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Commit 270637abff0cdf848b910b9f96ad342e1da61c66 introduced a lot new compiler warnings
2008-03-21 19:11 Commit 270637abff0cdf848b910b9f96ad342e1da61c66 introduced a lot new compiler warnings Gabriel C
@ 2008-03-21 22:43 ` David Miller
2008-03-21 23:07 ` Gabriel C
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-03-21 22:43 UTC (permalink / raw)
To: nix.or.die; +Cc: linux-kernel, vladislav.yasevich, sri, netdev
From: Gabriel C <nix.or.die@googlemail.com>
Date: Fri, 21 Mar 2008 20:11:18 +0100
> I noticed the following new compile warnings on current git head introduced by 270637abff0cdf848b910b9f96ad342e1da61c66 :
Please include netdev@vger.kernel.org for networking bug
reports in the future, thank you.
Thanks for the report, I'll push the following fix:
commit 1233823b0847190976d69a86d7bb1287992ba2c7
Author: David S. Miller <davem@davemloft.net>
Date: Fri Mar 21 15:40:47 2008 -0700
[SCTP]: Fix build warnings with IPV6 disabled.
Introduced by 270637abff0cdf848b910b9f96ad342e1da61c66
("[SCTP]: Fix a race between module load and protosw access")
Reported by Gabriel C:
In file included from net/sctp/sm_statetable.c:50:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
In file included from net/sctp/sm_statefuns.c:62:
include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
...
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
index 57ed3e3..ea80673 100644
--- a/include/net/sctp/sctp.h
+++ b/include/net/sctp/sctp.h
@@ -389,7 +389,7 @@ void sctp_v6_del_protocol(void);
#else /* #ifdef defined(CONFIG_IPV6) */
-static inline void sctp_v6_pf_init(void) { return 0; }
+static inline void sctp_v6_pf_init(void) { return; }
static inline void sctp_v6_pf_exit(void) { return; }
static inline int sctp_v6_protosw_init(void) { return 0; }
static inline void sctp_v6_protosw_exit(void) { return; }
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: Commit 270637abff0cdf848b910b9f96ad342e1da61c66 introduced a lot new compiler warnings
2008-03-21 22:43 ` David Miller
@ 2008-03-21 23:07 ` Gabriel C
0 siblings, 0 replies; 3+ messages in thread
From: Gabriel C @ 2008-03-21 23:07 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, vladislav.yasevich, sri, netdev
David Miller wrote:
> From: Gabriel C <nix.or.die@googlemail.com>
> Date: Fri, 21 Mar 2008 20:11:18 +0100
>
>> I noticed the following new compile warnings on current git head introduced by 270637abff0cdf848b910b9f96ad342e1da61c66 :
>
> Please include netdev@vger.kernel.org for networking bug
> reports in the future, thank you.
I usually do that and to be honest I thought I did , damn fingers.
Really sorry.
>
> Thanks for the report, I'll push the following fix:
>
> commit 1233823b0847190976d69a86d7bb1287992ba2c7
> Author: David S. Miller <davem@davemloft.net>
> Date: Fri Mar 21 15:40:47 2008 -0700
>
> [SCTP]: Fix build warnings with IPV6 disabled.
>
> Introduced by 270637abff0cdf848b910b9f96ad342e1da61c66
> ("[SCTP]: Fix a race between module load and protosw access")
>
> Reported by Gabriel C:
>
> In file included from net/sctp/sm_statetable.c:50:
> include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
> include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
> In file included from net/sctp/sm_statefuns.c:62:
> include/net/sctp/sctp.h: In function 'sctp_v6_pf_init':
> include/net/sctp/sctp.h:392: warning: 'return' with a value, in function returning void
> ...
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h
> index 57ed3e3..ea80673 100644
> --- a/include/net/sctp/sctp.h
> +++ b/include/net/sctp/sctp.h
> @@ -389,7 +389,7 @@ void sctp_v6_del_protocol(void);
>
> #else /* #ifdef defined(CONFIG_IPV6) */
>
> -static inline void sctp_v6_pf_init(void) { return 0; }
> +static inline void sctp_v6_pf_init(void) { return; }
> static inline void sctp_v6_pf_exit(void) { return; }
> static inline int sctp_v6_protosw_init(void) { return 0; }
> static inline void sctp_v6_protosw_exit(void) { return; }
>
It fixes all warnings , thx.
Gabriel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-21 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-21 19:11 Commit 270637abff0cdf848b910b9f96ad342e1da61c66 introduced a lot new compiler warnings Gabriel C
2008-03-21 22:43 ` David Miller
2008-03-21 23:07 ` Gabriel C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox