From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762217AbYCUUyy (ORCPT ); Fri, 21 Mar 2008 16:54:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760874AbYCUUyo (ORCPT ); Fri, 21 Mar 2008 16:54:44 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:41019 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756093AbYCUUyn (ORCPT ); Fri, 21 Mar 2008 16:54:43 -0400 Message-ID: <47E4208F.20601@garzik.org> Date: Fri, 21 Mar 2008 16:54:39 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: James Bottomley CC: Linus Torvalds , Linux Kernel Mailing List , Kay Sievers , Andrew Morton , linux-scsi@vger.kernel.org Subject: Re: [SCSI] fix media change events for polled devices References: <200803211559.m2LFxPi6017869@hera.kernel.org> <47E3EC67.4050404@garzik.org> <1206128318.2961.32.camel@localhost.localdomain> In-Reply-To: <1206128318.2961.32.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.4 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org James Bottomley wrote: > On Fri, 2008-03-21 at 10:31 -0700, Linus Torvalds wrote: >> On Fri, 21 Mar 2008, Jeff Garzik wrote: >>> And that is the fix -- initialize supported_events according to sr/sd's needs, >>> and revert this change (4d1566ed2100d074ccc654e5cf2e44cdea3a01d0) as obviously >>> broken. >> Patches, please? I can do the revert, but the patch to supported_events >> and the testing, please? > > I tested this and discussed it with Kristen before it went in. The > current fix you sucked in with scsi-rc-fixes basically makes the whole > lot work for 2.6.25 (both AN media change events and traditional polled > ones). The thing that doesn't work is the ability to turn off AN events > from user space, but that feature never worked anyway. Not true. Change the perm with chmod... But furthermore, change 4d1566ed renders the userspace interface /inconsistent/ even for the read-only case that we all acknowledge _does_ work. IOW, after your "fix", the userspace interface gives an incorrect picture of what events are/are not masked. If you don't have the time to complete work on commit 285e9670d91cdeb6b6693729950339cb45410fdc Author: Kay Sievers Date: Tue Aug 14 14:10:39 2007 +0200 [SCSI] sr,sd: send media state change modification events then revert _that_. Don't break my patch, just because yours (which came _after_ mine) doesn't work. Jeff