From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757085AbYCVVTt (ORCPT ); Sat, 22 Mar 2008 17:19:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753225AbYCVVTh (ORCPT ); Sat, 22 Mar 2008 17:19:37 -0400 Received: from terminus.zytor.com ([198.137.202.10]:48927 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbYCVVTh (ORCPT ); Sat, 22 Mar 2008 17:19:37 -0400 Message-ID: <47E577B9.1010403@zytor.com> Date: Sat, 22 Mar 2008 14:18:49 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: gorcunov@gmail.com CC: mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [patch 0/4] x86 - relocate_kernel cleanup References: <20080322210005.117475478@gmail.com> <47E576B9.6090205@zytor.com> In-Reply-To: <47E576B9.6090205@zytor.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org H. Peter Anvin wrote: > gorcunov@gmail.com wrote: >> The main purpose of this patches is to eliminate numeric constant and >> use predefined macroses. Please review. I've tested 64bit version on >> object level - it remains the same. Any comments are welcome. > > Looks good. Since you're doing work in this realm, you may also want to > replace the old TF_MASK etc macros with X86_EFLAGS_TF etc. That wasn't meant to be a comment specific to the relocate_kernel stuff, incidentally. -hpa