From: "H. Peter Anvin" <hpa@zytor.com>
To: yhlu.kernel@gmail.com
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: enable PAT for amd k8 and fam10h
Date: Mon, 24 Mar 2008 18:29:55 -0700 [thread overview]
Message-ID: <47E85593.4030104@zytor.com> (raw)
In-Reply-To: <200803241602.01957.yhlu.kernel@gmail.com>
Yinghai Lu wrote:
> [PATCH] x86: enable PAT for amd k8 and fam10h
>
> make known_pat_cpu to think amd k8 and fam10h is ok too.
>
> also make tom2 below to be WRBACK
>
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index f74505f..a9e1a27 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -49,6 +49,12 @@ static int pat_known_cpu(void)
> return 1;
> }
> }
> + if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD &&
> + boot_cpu_data.x86 >= 0xf && boot_cpu_data.x86 <= 0x11) {
> + if (cpu_has_pat) {
> + return 1;
> + }
> + }
>
> pat_wc_enabled = 0;
> printk(KERN_INFO "CPU and/or kernel does not support PAT.\n");
This really should be handled through a CPU flag. Specifically, it
should be handled by disabling the PAT flag if PAT is unusable or
suspect of being unusable; it should *NOT* be stashed away in a
completely separate piece of code.
-hpa
next prev parent reply other threads:[~2008-03-25 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 23:02 [PATCH] x86: enable PAT for amd k8 and fam10h Yinghai Lu
2008-03-25 1:29 ` H. Peter Anvin [this message]
2008-03-25 2:22 ` Yinghai Lu
2008-03-25 4:45 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E85593.4030104@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox