From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: enable PAT for amd k8 and fam10h
Date: Mon, 24 Mar 2008 21:45:53 -0700 [thread overview]
Message-ID: <47E88381.6030705@zytor.com> (raw)
In-Reply-To: <86802c440803241922u50fb33f8xb33118e22c2f7ad2@mail.gmail.com>
Yinghai Lu wrote:
>>
>> This really should be handled through a CPU flag. Specifically, it
>> should be handled by disabling the PAT flag if PAT is unusable or
>> suspect of being unusable; it should *NOT* be stashed away in a
>> completely separate piece of code.
>
> PAT patches in x86.git latest, only support some intel CPUs.
>
> if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL &&
> (boot_cpu_data.x86 == 0xF ||
> (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model >= 15))) {
> if (cpu_has_pat) {
> return 1;
> }
> }
>
> should be moved to setup_64.c?
>
Yes, which in turn should be merged with the 32-bit code in cpu/*.c.
Personally I would prefer a blacklist rather than a whitelist, but
that's nitpicking.
-=hpa
prev parent reply other threads:[~2008-03-25 4:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 23:02 [PATCH] x86: enable PAT for amd k8 and fam10h Yinghai Lu
2008-03-25 1:29 ` H. Peter Anvin
2008-03-25 2:22 ` Yinghai Lu
2008-03-25 4:45 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E88381.6030705@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox