Re: [PATCH 4/4] ACPI PCI slot detection driver

Matthew Wilcox
2008-03-11T13:28:29Z

On Tue, Mar 11, 2008 at 10:10:40PM +0900, Kenji Kaneshige wrote:
> 1) I checked ACPI spec again and again, but I could not find any
> reason to add Fujitsu servers to quirks list. So I'd like you to
> add HP servers to the quirks list. I'll send the following patches
> followed by this e-mail.

Alex pointed out that IBM interprets the spec the same way that HP does.
Are there any other machines that follow the spec the same way that
Fujitsu does?

> 2) The ACPI PCI slot detection driver would change the slot names of
> some hotplug drivers (at least I checked shpchp and pciehp). And
> the name of slots are depending on the order of driver loading.
> For example, on my system which has several SHPCHP slots and
> PCIEHP slots, the name of PCIEHP slots are changed as
> follows. Please note that PCIEHP based slots are 0034_0027 and
> 0032_0026, and others are SHPCHP based slots.
>
> - Without ACPI PCI slot detection driver
> # ls /sys/bus/pci/slots/
> 0009_0016 0014_0018 0019_0020 0021_0022 0034_0027
> 0011_0017 0016_0019 0021_0021 0032_0026
>
> - With ACPI PCI slot detection driver
> # ls /sys/bus/pci/slots/
> 0009_0016 0014_0018 0019_0020 0021_0022 27
> 0011_0017 0016_0019 0021_0021 26

I hadn't realised that patch got in to put the bus name in as a
uniquifier. I thought we'd rejected it because the problem only
occurred on one box with bad firmware.

> - Unify slot names among all hotplug drivers

That is the plan. I'm not sure why the shpc slots aren't renamed in
this revision of the patch -- maybe Alex dropped that part?

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."