From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarod Wilson <jwilson@redhat.com>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler
Date: Thu, 27 Mar 2008 08:56:53 +0100 [thread overview]
Message-ID: <47EB5345.6080506@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.82d28d7bc55f2a9b@s5r6.in-berlin.de>
I wrote:
> I wrote:
>> On the other hand, why do we free a page + allocate a page?
>> Why don't we re-initialize and re-add the old page?
>
> Meanwhile I tried a simple modification to ar_context_add_page and its
> callers which results in _add_page simply re-adding the old page. I must
> do something fundamentally wrong though.
Besides, the current code which reassembles packets that reach into the
next buffer is broken for packets whose total size approaches PAGE_SIZE.
(Remember, async packets can be sized 4kB + 1394 headers + OHCI
trailer.) Reminds me of ohci1394 somehow. :-(
I will attempt to fix this for post 2.6.25, unless you aspire to do so.
--
Stefan Richter
-=====-==--- --== ==-==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-03-27 7:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 20:47 [PATCH] firewire: fw-ohci: plug dma memory leak in AR handler Jarod Wilson
2008-03-25 22:29 ` Stefan Richter
2008-03-26 7:09 ` Stefan Richter
2008-03-26 13:09 ` Jarod Wilson
2008-03-26 23:50 ` Stefan Richter
2008-03-27 7:56 ` Stefan Richter [this message]
2008-03-26 21:37 ` Jarod Wilson
2008-03-27 0:12 ` Stefan Richter
2008-03-27 2:17 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EB5345.6080506@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jwilson@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox