From: Roel Kluin <12o3l@tiscali.nl>
To: dwalker@mvista.com, nickpiggin@yahoo.com.au
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] likeliness accounting cleanup
Date: Thu, 27 Mar 2008 13:37:31 +0100 [thread overview]
Message-ID: <47EB950B.6030908@tiscali.nl> (raw)
In-Reply-To: <47EAB608.6060204@tiscali.nl>
Roel Kluin wrote:
> Store __builtin_return_address (caller) rather than __func__ in likeliness
> struct. 'line' and 'type' are combined in 'label'
>
> +/- now denotes whether expectation fails in less than 5% of the tests - rather
> than whether more unexpected than expected were encountered. The function at
> the displayed filename & line and the caller are not necessarily the same.
> A few more Likely Profiling Results changes were made.
>
> struct seq_operations becomes static, unsigned ints true and false (shadowed)
> are replaced by pos and neg.
> ---
> New layout:
>
> Likely Profiling Results
> --------------------------------------------------------------------
> [+- ]Type | # True | # False | Function@Filename:Line
> unlikely | 0| 32082| fget+0xd0/0x1d0@include/asm/arch/atomic_32.h:235
>
> Compiles and runs here. Thanks for previous comments.
>
> include/linux/compiler.h | 16 ++++++++--------
> lib/likely_prof.c | 45 +++++++++++++++++++++++++--------------------
> 2 files changed, 33 insertions(+), 28 deletions(-)
>
This should be applied after the -mm patches:
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/profile-likely-unlikely-macros.patch
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/broken-out/profile-likely-unlikely-macros-fix.patch
Also I forgot to add a signoff, so here it is:
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
next prev parent reply other threads:[~2008-03-27 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 20:46 [PATCH v2] likeliness accounting cleanup Roel Kluin
2008-03-27 12:37 ` Roel Kluin [this message]
2008-03-27 16:45 ` Daniel Walker
2008-03-27 20:25 ` [PATCH v2 -mm] likeliness accounting change and cleanup Roel Kluin
2008-03-28 5:09 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EB950B.6030908@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox