public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: processor flags
Date: Thu, 27 Mar 2008 12:55:42 -0700	[thread overview]
Message-ID: <47EBFBBE.4060404@zytor.com> (raw)
In-Reply-To: <20080327194749.GA7633@cvg>

Cyrill Gorcunov wrote:
> 
> And now I'm in confusion - the way of changing this code I see is the
> following:
> 
> - or use additional #ifdef CONFIG_VM86 in code where VM_MASK is used
>   (that would be ugly IMHO)
> - rename VM_MASK to say X86_EFLAGS_VM86 with that #ifdef remained
> - rest VM_MASK as it is
> 
> How do you think?
> 

I think what we should do is:

- Rename VM_MASK to X86_VM_MASK (it's x86-specific after all)
- Have:

#if CONFIG_VM86
# define X86_VM_MASK X86_EFLAGS_VM
#else
# define X86_VM_MASK 0		/* No V86 support */
#endif

	-hpa

  reply	other threads:[~2008-03-27 19:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 19:47 processor flags Cyrill Gorcunov
2008-03-27 19:55 ` H. Peter Anvin [this message]
2008-03-27 19:56   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EBFBBE.4060404@zytor.com \
    --to=hpa@zytor.com \
    --cc=gorcunov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox