From: Jiri Slaby <jirislaby@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Linux and Kernel Video <video4linux-list@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: v4l & compat_ioctl
Date: Fri, 28 Mar 2008 12:31:33 +0100 [thread overview]
Message-ID: <47ECD715.90507@gmail.com> (raw)
In-Reply-To: <87y783jdjo.fsf@basil.nowhere.org>
On 03/28/2008 12:25 PM, Andi Kleen wrote:
> However the new standard way to do this is to not
> add new stuff into compat_ioctl.c, but define ->compat_ioctl
> entry points in the low level drivers (and ideally converted
> them to ->unlocked_ioctl too while you're at it)
Andi, the problem here is, that v4l has only open in fops which in turn changes
fops to the driver's one, so this would mean change all the drivers in v4l...
I second the converting to unlocked_ioctl and compat_ioctl in longer term (for
new drivers as a merging rule), but wouldn't be feasible to add them to compat
ioctl for now?
next prev parent reply other threads:[~2008-03-28 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 11:04 v4l & compat_ioctl Jiri Slaby
2008-03-28 11:25 ` Andi Kleen
2008-03-28 11:31 ` Jiri Slaby [this message]
2008-03-28 11:38 ` Andi Kleen
2008-03-28 12:22 ` Jiri Slaby
2008-03-28 13:35 ` Andi Kleen
2008-03-28 17:24 ` Mauro Carvalho Chehab
2008-03-28 17:26 ` Jiri Slaby
2008-03-28 17:47 ` Mauro Carvalho Chehab
2008-03-28 18:07 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ECD715.90507@gmail.com \
--to=jirislaby@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox