From: Randy Dunlap <randy.dunlap@oracle.com>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: Sebastien Dugue <sebastien.dugue@bull.net>,
dsd@gentoo.org, trivial@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix typos in Documentation/unaligned-memory-access.txt
Date: Fri, 28 Mar 2008 13:58:29 -0700 [thread overview]
Message-ID: <47ED5BF5.4000809@oracle.com> (raw)
In-Reply-To: <47ED5B3F.7040401@gmail.com>
Dmitri Vorobiev wrote:
> Sebastien Dugue wrote:
>> Hi Dmitri,
>>
>> one more typo I guess:
>>
>> On Fri, 28 Mar 2008 13:10:42 +0300 Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:
>>
>>> This patch deletes a couple of superfluous word occurrences in the
>>> document Documentation/unaligned-memory-access.txt.
>>> ---
>>> Sorry for a duplicate email, I forgot to Cc LKML when sending the patch.
>>>
>>> Documentation/unaligned-memory-access.txt | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/unaligned-memory-access.txt b/Documentation/unaligned-memory-access.txt
>>> index 6223eac..ed57b53 100644
>>> --- a/Documentation/unaligned-memory-access.txt
>>> +++ b/Documentation/unaligned-memory-access.txt
>>> @@ -57,7 +57,7 @@ here; a summary of the common scenarios is presented below:
>>> unaligned access to be corrected.
>>> - Some architectures are not capable of unaligned memory access, but will
>>> silently perform a different memory access to the one that was requested,
>>> - resulting a a subtle code bug that is hard to detect!
>>> + resulting a subtle code bug that is hard to detect!
>> ^
>> in a
>
> Although those English dictionaries that I have consulted do indicate that
> "result" is an intransitive verb, there are many occurrences reported by Google
> when this verb takes a direct object like in the following phrase: "However,
> inner space of the stand 2 of the drum washing machine 1 is not used,
> resulting a problem of wasting space."
>
> English is not my mother tongue so I can't claim I have a good ear for the
> language. Are there any native speakers who could help, please?
I'll ack the "in a" change.
> Dmitri
>
>> Sebastien.
>>
>>>
>>> It should be obvious from the above that if your code causes unaligned
>>> memory accesses to happen, your code will not work correctly on certain
>>> @@ -209,7 +209,7 @@ memory and you wish to avoid unaligned access, its usage is as follows:
>>>
>>> u32 value = get_unaligned((u32 *) data);
>>>
>>> -These macros work work for memory accesses of any length (not just 32 bits as
>>> +These macros work for memory accesses of any length (not just 32 bits as
>>> in the examples above). Be aware that when compared to standard access of
>>> aligned memory, using these macros to access unaligned memory can be costly in
>>> terms of performance.
>
--
~Randy
prev parent reply other threads:[~2008-03-28 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 10:10 [PATCH 1/1] Fix typos in Documentation/unaligned-memory-access.txt Dmitri Vorobiev
2008-03-28 12:23 ` Sebastien Dugue
2008-03-28 20:55 ` Dmitri Vorobiev
2008-03-28 20:58 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED5BF5.4000809@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=dmitri.vorobiev@gmail.com \
--cc=dsd@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastien.dugue@bull.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox