From: Jeremy Fitzhardinge <jeremy@goop.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Christoph Lameter <clameter@sgi.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2 of 4] hotplug-memory: adding non-section-aligned memory is bad
Date: Fri, 28 Mar 2008 14:30:16 -0700 [thread overview]
Message-ID: <47ED6368.3070708@goop.org> (raw)
In-Reply-To: <20080328113312.65cca8b5.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> For example, mem_notify() in online_pages() will be called several times against
> a section.
>
It seems the only in-tree user of the notifier is mm/slub.c, and it only
cares about MEM_GOING_ONLINE, GOING_OFFLINE, OFFLINE and CANCEL_ONLINE
(not ONLINE or CANCEL_OFFLINE).
Also,
if (onlined_pages)
memory_notify(MEM_ONLINE, &arg);
doesn't seem correct, because arg.nr_pages still has the original
nr_pages, and not the number of pages actually onlined (onlined_pages).
Also arg.start_pfn isn't terribly meaningful if a discontiguous set of
pages can be actually onlined.
J
next prev parent reply other threads:[~2008-03-28 21:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 0:28 [PATCH 0 of 4] [RFC] hotplug memory: minor updates Jeremy Fitzhardinge
2008-03-28 0:28 ` [PATCH 1 of 4] hotplug-memory: add add_memory_resource Jeremy Fitzhardinge
2008-03-28 0:28 ` [PATCH 2 of 4] hotplug-memory: adding non-section-aligned memory is bad Jeremy Fitzhardinge
2008-03-28 1:27 ` KAMEZAWA Hiroyuki
2008-03-28 1:34 ` Yasunori Goto
2008-03-28 1:54 ` KAMEZAWA Hiroyuki
2008-03-28 2:13 ` Jeremy Fitzhardinge
2008-03-28 2:33 ` KAMEZAWA Hiroyuki
2008-03-28 2:51 ` Jeremy Fitzhardinge
2008-03-28 3:17 ` KAMEZAWA Hiroyuki
2008-03-28 4:20 ` Jeremy Fitzhardinge
2008-03-28 4:39 ` KAMEZAWA Hiroyuki
2008-03-28 18:19 ` Jeremy Fitzhardinge
2008-03-28 18:27 ` Dave Hansen
2008-03-28 3:21 ` Yasunori Goto
2008-03-28 4:07 ` Jeremy Fitzhardinge
2008-03-28 21:30 ` Jeremy Fitzhardinge [this message]
2008-03-28 0:28 ` [PATCH 3 of 4] sparsemem: reduce i386 PAE section size Jeremy Fitzhardinge
2008-03-28 0:35 ` Christoph Lameter
2008-03-28 2:26 ` Jeremy Fitzhardinge
2008-03-28 2:27 ` Christoph Lameter
2008-03-28 6:18 ` Jeremy Fitzhardinge
2008-03-28 16:43 ` Dave Hansen
2008-03-28 18:05 ` Jeremy Fitzhardinge
2008-03-28 16:45 ` Dave Hansen
2008-03-28 0:28 ` [PATCH 4 of 4] paravirt_ops: don't steal memory resources in paravirt_disable_iospace Jeremy Fitzhardinge
2008-03-28 2:41 ` Rusty Russell
2008-03-28 9:12 ` [PATCH 0 of 4] [RFC] hotplug memory: minor updates Ingo Molnar
2008-03-28 16:07 ` Jeremy Fitzhardinge
2008-03-28 22:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED6368.3070708@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dave@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox